aboutsummaryrefslogtreecommitdiff
path: root/src/addrman.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Creates unittests for addrman, makes addrman testable.EthanHeilman2015-09-241-2/+6
| | | | | Adds several unittests for addrman to verify it works as expected. Makes small modifications to addrman to allow deterministic and targeted tests.
* Improve addrman Select() performance when buckets are nearly emptyPieter Wuille2015-08-261-4/+8
|
* remove using namespace std from addrman.cppPhilip Kaufmann2015-06-151-5/+3
|
* Merge pull request #6028Wladimir J. van der Laan2015-04-241-2/+2
|\ | | | | | | 1d5b47a nLastTry is only used for addrman entries (Pieter Wuille)
| * nLastTry is only used for addrman entriesPieter Wuille2015-04-191-2/+2
| | | | | | | | No need to define it for every CAddress, as it's memory only anyway.
* | Cap nAttempts penalty at 8 and switch to pow instead of a division loop.Gregory Maxwell2015-04-191-3/+2
|/ | | | | | | | On hosts that had spent some time with a failed internet connection their nAttempts penalty was going through the roof (e.g. thousands for all peers) and as a result the connect search was pegging the CPU and failing to get more than a 4 connections after days of running (because it was taking so long per try).
* Always use a 50% chance to choose between tried and new entriesPieter Wuille2015-03-231-4/+3
| | | | | | | This change was suggested as Countermeasure 2 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
* Do not bias outgoing connections towards fresh addressesPieter Wuille2015-03-231-2/+0
| | | | | | | This change was suggested as Countermeasure 2 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015.
* Simplify hashing codePieter Wuille2015-03-231-21/+5
|
* Make addrman's bucket placement deterministic.Pieter Wuille2015-03-231-146/+124
| | | | | | | | | | | | | | | Give each address a single fixed location in the new and tried tables, which become simple fixed-size arrays instead of sets and vectors. This prevents attackers from having an advantages by inserting an address multiple times. This change was suggested as Countermeasure 1 in Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman, Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report 2015/263. March 2015. It is also more efficient.
* Switch addrman key from vector to uint256Pieter Wuille2015-03-231-6/+8
|
* Reduce fingerprinting through timestamps in 'addr' messages.Pieter Wuille2015-03-171-1/+2
| | | | Suggested by Jonas Nick.
* Replace GetLow64 with GetCheapHashWladimir J. van der Laan2015-01-051-4/+4
|
* Merge pull request #5119Pieter Wuille2014-10-271-0/+1
|\ | | | | | | fa73619 boost: split stream classes out of serialize.h (Cory Fields)
| * boost: split stream classes out of serialize.hCory Fields2014-10-221-0/+1
| | | | | | | | serialization now has no dependencies.
* | Update comments in addrman to be doxygen compatibleMichael Ford2014-10-241-4/+4
|/ | | | Also correct the file license
* Apply clang-format on some infrequently-updated filesPieter Wuille2014-09-191-115/+110
|
* Improve readability of CAddrInfo::IsTerribleTeran McKinney2014-09-051-3/+3
| | | | | | | - Replaced 86400 with 24*60*60 - Remove references to specific timespans in comments Github-Pull: #4724
* addrman: Do not propagate obviously poor addresses onto the networkJeff Garzik2014-08-181-4/+10
|
* Remove redundant .c_str()sWladimir J. van der Laan2014-01-231-1/+1
| | | | | | | After the tinyformat switch sprintf() family functions support passing actual std::string objects. Remove unnecessary c_str calls (236 of them) in logging and formatting.
* Changed Get64(.) to GetLow64()Thomas Holenstein2013-12-251-4/+4
| | | | | | | The function Get64(.) has a bug in case the width is not divisible by 64. Since it is only ever used as Get64(0) this simply changes it to this special case. Additionally, an assert is added, and a cast to prevent a compiler error.
* Cleanup code using forward declarations.Brandon Dahler2013-11-101-17/+19
| | | | | | | | | Use misc methods of avoiding unnecesary header includes. Replace int typedefs with int##_t from stdint.h. Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h. Normalize QT_VERSION ifs where possible. Resolve some indirect dependencies as direct ones. Remove extern declarations from .cpp files.
* Replace printf with LogPrintf / LogPrintGavin Andresen2013-09-181-4/+1
|
* Split off hash.h from util.hPieter Wuille2012-12-181-0/+1
|
* Trim trailing whitespace for src/*.{h,cpp}Jeff Garzik2012-09-181-2/+2
|
* fix a comment in addrman.cppPhilip Kaufmann2012-08-181-1/+1
|
* Update License in File HeadersFordy2012-05-181-1/+1
| | | | | | I originally created a pull to replace the "COPYING" in crypter.cpp and crypter.h, but it turned out that COPYING was actually the correct file.
* Clean up warningsPieter Wuille2012-05-091-3/+2
| | | | | | * Use -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameters * Remove xCXXFLAGS usage in makefile.unix * Fix several recent and older sign-compare warnings
* Fix addrman crashesPieter Wuille2012-05-051-2/+5
| | | | | | | | | A function returned the element to remove from a bucket, instead of its position in that bucket. This function was only called when a tried bucket overflowed, which only happens after many outgoing connections have been made. Closes: #1065, #1156
* Add extra asserts to addrmanPieter Wuille2012-05-051-0/+19
|
* Further reduce header dependenciesPieter Wuille2012-04-171-4/+4
| | | | | | | This commit removes the dependency of serialize.h on PROTOCOL_VERSION, and makes this parameter required instead of implicit. This is much saner, as it makes the places where changing a version number can have an influence obvious.
* Fix loop index var types, fixing many minor sign comparison warningsJeff Garzik2012-04-151-2/+2
| | | | | foo.size() typically returns an unsigned integral type; make loop variables match those types' signedness.
* fix warnings: '&&' within '||' [-Wlogical-op-parentheses]Wladimir J. van der Laan2012-04-151-1/+1
|
* CAddrMan: stochastic address managerPieter Wuille2012-02-241-0/+506
Design goals: * Only keep a limited number of addresses around, so that addr.dat does not grow without bound. * Keep the address tables in-memory, and occasionally write the table to addr.dat. * Make sure no (localized) attacker can fill the entire table with his nodes/addresses. See comments in addrman.h for more detailed information.