aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* depends: fix a static qt5 crash when using certain versions of libxcbCory Fields2015-03-162-20/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See here for background: https://bugreports.qt.io/browse/QTBUG-34748 libxcb temporarily had an abi breakage which caused crashes when qt was compiled against a non-compatible version. Building qt with -qt-xcb should have shielded us from this issue, except that incompatible headers were used when building qt's wrapper. Make sure those headers aren't picked up by qt's build. Details: qt's build adds a wrapper around the xcb libs when -qt-xcb is used. This is done to avoid having to link to a handful of different libs, which may not be api/abi stable. This build depends on include-order, so that its files are found before the real libxcb headers. Our build (for other reasons related to qt's complicated build-system) injects our prefix into CXXFLAGS. Because libxcb is found in this path, that reverses the include-order, negating the purpose of the wrapper. To fix, libxcb's includes are simply moved to a subdir. pkg-config ensures that they're still found properly when needed. To make things even more interesting, this behavior in qt's .pro files is broken: INCLUDEPATH += $$QMAKE_CFLAGS_XCB The INCLUDEPATH variable is processed by qmake which automatically prefixes each entry with "-I". The QMAKE_CFLAGS_XCB variable comes from pkg-config and already contains -I, making the path look like "-I-I/path/to/xcb/headers". To work around that, CFLAGS/CXXFLAGS are used here rather than INCLUDEPATH.
* Merge pull request #5880Wladimir J. van der Laan2015-03-163-41/+31
|\ | | | | | | | | 8b60808 [QT] some mac specifiy cleanup (memory handling, unnecessary code) (Jonas Schnelli) 89e70e9 [QT] fix OSX dock icon window reopening (Jonas Schnelli)
| * [QT] some mac specifiy cleanup (memory handling, unnecessary code)Jonas Schnelli2015-03-133-10/+7
| |
| * [QT] fix OSX dock icon window reopeningJonas Schnelli2015-03-121-31/+24
| | | | | | | | fixes #5878
* | Merge pull request #5847Wladimir J. van der Laan2015-03-163-1/+79
|\ \ | | | | | | | | | 723664b startup script for centos, with documentation. (joshr)
| * | startup script for centos, with documentation.joshr2015-03-033-1/+79
| | |
* | | Merge pull request #5831Wladimir J. van der Laan2015-03-1616-89/+290
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 1d9b378 qa/rpc-tests/wallet: Tests for sendmany (Luke Dashjr) 40a7573 rpcwallet/sendmany: Just take an array of addresses to subtract fees from, rather than an Object with all values being identical (Luke Dashjr) 292623a Subtract fee from amount (Cozz Lovan) 90a43c1 [Qt] Code-movement-only: Format confirmation message in sendcoinsdialog (Cozz Lovan)
| * | | qa/rpc-tests/wallet: Tests for sendmanyLuke Dashjr2015-03-131-2/+16
| | | |
| * | | rpcwallet/sendmany: Just take an array of addresses to subtract fees from, ↵Luke Dashjr2015-03-131-11/+11
| | | | | | | | | | | | | | | | rather than an Object with all values being identical
| * | | Subtract fee from amountCozz Lovan2015-03-1316-62/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #2724 and #1570. Adds the automatically-subtract-the-fee-from-the-amount-and-send-whats-left feature to the GUI and RPC (sendtoaddress,sendmany).
| * | | [Qt] Code-movement-only: Format confirmation message in sendcoinsdialogCozz Lovan2015-03-051-29/+30
| | | |
* | | | Merge pull request #5849Wladimir J. van der Laan2015-03-161-2/+4
|\ \ \ \ | | | | | | | | | | | | | | | 3c6d594 contrib/init/bitcoind.openrc: Compatibility with previous OpenRC init script variables (Luke Dashjr)
| * | | | contrib/init/bitcoind.openrc: Compatibility with previous OpenRC init script ↵Luke Dashjr2015-03-031-2/+4
| | | | | | | | | | | | | | | | | | | | variables
* | | | | Merge pull request #5884Wladimir J. van der Laan2015-03-121-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | e96c518 BUGFIX: Stack around the variable 'rv' was corrupted (fsb4000)
| * | | | | BUGFIX: Stack around the variable 'rv' was corruptedfsb40002015-03-121-2/+2
| | | | | |
* | | | | | Merge pull request #5879Wladimir J. van der Laan2015-03-122-1/+52
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | 88f6c8c add RPC test for InvalidateBlock (Alex Morcos) a9af415 fix InvalidateBlock to repopulate setBlockIndexCandidates (Alex Morcos)
| * | | | | add RPC test for InvalidateBlockAlex Morcos2015-03-121-0/+51
| | | | | |
| * | | | | fix InvalidateBlock to repopulate setBlockIndexCandidatesAlex Morcos2015-03-121-1/+1
|/ / / / /
* | | | | Merge pull request #5859Wladimir J. van der Laan2015-03-122-2/+34
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 9519a9a Add correct bool combiner for net signals (Pieter Wuille)
| * | | | | Add correct bool combiner for net signalsPieter Wuille2015-03-062-2/+34
| | | | | |
* | | | | | Merge pull request #5883Wladimir J. van der Laan2015-03-1235-36/+90
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | | | | | | | 92fd887 tests: add a BasicTestingSetup and apply to all tests (Wladimir J. van der Laan)
| * | | | | tests: add a BasicTestingSetup and apply to all testsWladimir J. van der Laan2015-03-1235-36/+90
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure that chainparams and logging is properly initialized. Doing this for every test may be overkill, but this initialization is so simple that that does not matter. This should fix the travis issues.
* | | | | Merge pull request #5871Wladimir J. van der Laan2015-03-118-83/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 3aa0130 test: remove fSkipProofOfWork (Wladimir J. van der Laan) 59bd89f test: Remove UNITTEST params (Wladimir J. van der Laan)
| * | | | | test: remove fSkipProofOfWorkWladimir J. van der Laan2015-03-094-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not used, and REGTEST already allows creating blocks at the lowerst possible difficulty.
| * | | | | test: Remove UNITTEST paramsWladimir J. van der Laan2015-03-096-74/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UNITTEST parameter are not used by any current tests, and the model (modifyable parameters) is inconvenient when unit-testing. As they are stored in a global structure eevery test would have to (re)set up its own parameters. For consistency it is also better to test with MAIN parameters.
* | | | | | Merge pull request #5749Wladimir J. van der Laan2015-03-116-215/+230
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | f754707 Fix - bitcoin-qt usage message (Luca Venturini) 1fdb9fa Help messages correctly formatted (79 chars) (Luca Venturini)
| * | | | | | Fix - bitcoin-qt usage messageLuca Venturini2015-03-102-54/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | . Closes the bug from commit e179eb3d9bfec7e67908242c71c87b716a41c97c ("bitcoin-qt -help" did not show any message) . Move all the options in init.cpp (there were already some options related to bitcoin-qt)
| * | | | | | Help messages correctly formatted (79 chars)Luca Venturini2015-03-105-161/+193
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Help messages are formatted programmatically with FormatParagraph in order not to break existing strings in Transifex. The new format works even if the translation of the strings modifies the lenght of the message. Sqashed 6 commits in a single one. Help messages correctly formatted for SVGA text mode (132 chars) Help messages are formatted programmatically with FormatParagraph in order not to break existing strings in Transifex. The new format should work even if the translation of the strings modifies the lenght of the message. Fix - syntax error Correct formatting for 79 chars Correctly based on C++ functions Removed spare spaces from option strings Fix - syntax error
* | | | | | Merge pull request #5864Wladimir J. van der Laan2015-03-111-1/+4
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | bb6acff fix possible block db breakage during re-index (Cory Fields)
| * | | | | fix possible block db breakage during re-indexCory Fields2015-03-101-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When re-indexing, there are a few cases where garbage data may be skipped in the block files. In these cases, the indices are correctly written to the index db, however the pointer to the next position for writing in the current block file is calculated by adding the sizes of the valid blocks found. As a result, when the re-index is finished, the index db is correct for all existing blocks, but the next block will be written to an incorrect offset, likely overwriting existing blocks. Rather than using the sum of all valid blocks to determine the next write position, use the end of the last block written to the file. Don't assume that the current block is the last one in the file, since they may be read out-of-order.
* | | | | | tests: change main and wallet tests to BOOST_FIXTURE_TEST_SUITEWladimir J. van der Laan2015-03-092-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid this travis error: test_bitcoin: chainparams.cpp:330: const CChainParams& Params(): Assertion `pCurrentParams' failed. unknown location(0): fatal error in "subsidy_limit_test": signal: SIGABRT (application abort requested) test/allocator_tests.cpp(116): last checkpoint
* | | | | | Merge pull request #5852Wladimir J. van der Laan2015-03-0914-61/+124
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | 51598b2 Reinitialize state in between individual unit tests. (Pieter Wuille)
| * | | | | | Reinitialize state in between individual unit tests.Pieter Wuille2015-03-0314-61/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the TestingSetup fixture to be per-unit-test rather than global. Most tests don't need it, so it's only invoked in a few.
* | | | | | | Merge pull request #5442Wladimir J. van der Laan2015-03-091-1/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | dca799e Ignore getaddr messages on Outbound connections. (Ivan Pustogarov)
| * | | | | | | Ignore getaddr messages on Outbound connections.Ivan Pustogarov2015-02-061-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The only time when a client sends a "getaddr" message is when he esatblishes an Outbound connection (see ProcessMessage() in src/main.cpp). Another bitcoin client is expected to receive a "getaddr" message only on Inbound connection. Ignoring "gettaddr" requests on Outbound connections can resolve potential privacy issues (and as was said such request normally do not happen anyway).
* | | | | | | | Merge pull request #5776Wladimir J. van der Laan2015-03-097-23/+28
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 8517e97 [Qt] rework setNumBlocks to have blockDate as parameter (Philip Kaufmann)
| * | | | | | | | [Qt] rework setNumBlocks to have blockDate as parameterPhilip Kaufmann2015-03-097-23/+28
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | - reduces some functional overhead and simplifies the code
* | | | | | | | Merge pull request #5858Wladimir J. van der Laan2015-03-091-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 9bbb880 [Qt] fix a issue where "command line options"-action overwrite "Preference"-action (on OSX) (Jonas Schnelli)
| * | | | | | | | [Qt] fix a issue where "command line options"-action overwrite ↵Jonas Schnelli2015-03-061-0/+1
| | |_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "Preference"-action (on OSX) - fixes #5800
* | | | | | | | Merge pull request #5855Wladimir J. van der Laan2015-03-091-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6986643 Run unit tests in different orders (Gavin Andresen)
| * | | | | | | | Run unit tests in different ordersGavin Andresen2015-03-061-0/+1
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set the BOOST_TEST_RANDOM environment variable, to run unit tests in different orders for each test in the test matrix that runs tests.
* | | | | | | | Merge pull request #5793Wladimir J. van der Laan2015-03-091-11/+35
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6cb4a52 [Qt, Linux] honor current network when creating autostart link (Philip Kaufmann) 9673c35 [Qt, Win] honor current network when creating autostart link (Philip Kaufmann)
| * | | | | | | | [Qt, Linux] honor current network when creating autostart linkPhilip Kaufmann2015-02-191-3/+8
| | | | | | | | |
| * | | | | | | | [Qt, Win] honor current network when creating autostart linkPhilip Kaufmann2015-02-191-8/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - creates a "Bitcoin (testnet).lnk" when on testnet or a "Bitcoin (regtest).lnk, when on regtest - fixes #5778
* | | | | | | | | Merge pull request #5151Pieter Wuille2015-03-076-18/+17
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | eec3713 make CMessageHeader a dumb storage class (Cory Fields)
| * | | | | | | | make CMessageHeader a dumb storage classCory Fields2015-02-256-18/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It shouldn't know or care about bitcoind's chain param selection
* | | | | | | | | Merge pull request #5510Wladimir J. van der Laan2015-03-0616-166/+530
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a0ae79d Replace CBlockHeader::GetHash with call to SerializeHash (Wladimir J. van der Laan) 62b30f0 Add serialize float/double tests (Wladimir J. van der Laan) 9f4fac9 src/txmempool.cpp: make numEntries a uint32_t (Wladimir J. van der Laan) f4e6487 src/arith_256.cpp: bigendian compatibility (Wladimir J. van der Laan) aac3205 src/netbase.h: Fix endian in CNetAddr serialization (Wladimir J. van der Laan) 01f9c34 src/serialize.h: base serialization level endianness neutrality (Wladimir J. van der Laan) 4e853aa src/script/script.h: endian compatibility for PUSHDATA sizes (Wladimir J. van der Laan) 4f92773 src/primitives/transaction.h: endian compatibility in serialization (Wladimir J. van der Laan) 81aeb28 src/primitives/block.cpp: endian compatibility in GetHash (Wladimir J. van der Laan) dec84ca src/net.cpp: endian compatibility in EndMessage (Wladimir J. van der Laan) 556814e src/main.cpp: endian compatibility in packet checksum check (Wladimir J. van der Laan) 3ca5852 src/hash.cpp: endian compatibility (Wladimir J. van der Laan) 4414f5f build: Endian compatibility (Wladimir J. van der Laan)
| * | | | | | | | | Replace CBlockHeader::GetHash with call to SerializeHashWladimir J. van der Laan2015-03-061-12/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes variability between LE and BE. As suggested by @sipa.
| * | | | | | | | | Add serialize float/double testsWladimir J. van der Laan2015-03-061-3/+93
| | | | | | | | | |
| * | | | | | | | | src/txmempool.cpp: make numEntries a uint32_tWladimir J. van der Laan2015-03-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't ever serialize a size_t or long, their sizes are platform dependent.