aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Change the default maximum OP_RETURN size to 80 bytesFlavien Charlon2014-11-141-1/+1
| | | | | The value can be changed through the '-datacarriersize' option, this is modifying the default value for that option.
* Merge pull request #5198Wladimir J. van der Laan2014-11-131-78/+100
|\ | | | | | | 1c0aa91 Update serialize comments to be doxygen compatible (Michael Ford)
| * Update serialize comments to be doxygen compatibleMichael Ford2014-10-311-78/+100
| |
* | Merge pull request #5252Wladimir J. van der Laan2014-11-137-63/+85
|\ \ | | | | | | | | | b9a36b1 Make comments in /src/script doxygen compatible (Michael Ford)
| * | Make comments in /src/script doxygen compatibleMichael Ford2014-11-107-63/+85
| | |
* | | Merge pull request #5203Wladimir J. van der Laan2014-11-131-1/+0
|\ \ \ | | | | | | | | | | | | 0d91ae3 The first thing that SelectParams does is call SelectBaseParams. Therefore, we do not need to call SelectBaseParams immediately prior to calling SelectParams. (mruddy)
| * | | The first thing that SelectParams does is call SelectBaseParams. Therefore, ↵mruddy2014-11-041-1/+0
| | | | | | | | | | | | | | | | we do not need to call SelectBaseParams immediately prior to calling SelectParams.
* | | | Merge pull request #5268Wladimir J. van der Laan2014-11-133-5/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | c8b115e travis: temporarily disable the forknotify test (Cory Fields) 1877390 depends: cleanup better after qt and force a bump (Cory Fields) 560e996 travis: attempt to fix unlikely build issue (Cory Fields)
| * | | | travis: temporarily disable the forknotify testCory Fields2014-11-131-1/+1
| | | | | | | | | | | | | | | | | | | | It appears to be breaking randomly on Windows
| * | | | depends: cleanup better after qt and force a bumpCory Fields2014-11-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | qt needs to be rebuilt for travis. The previous commit should help ensure that this won't need to be done again.
| * | | | travis: attempt to fix unlikely build issueCory Fields2014-11-131-3/+3
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a long chain of errors, and there are likely other changes that could be made to cope in other places along that chain. If depends don't build successfully, don't bother trying again for the sake of better logging. That's likely to hurt more than help. In this case, qt build failed, and on the second attempt, it appeared to be successful. However, due to a bad object from an internal gcc error on the first build, the resulting lib was unusable. This caused bitcoin-qt to not be built, and tests and packaging which expected bitcoin-qt to be there failed. The root cause: Mingw is especially crashy when using -jX, likely compounded by low-memory environments. I've seen multiple problems with this combo in Gitian as well. In this case: i686-w64-mingw32-g++: internal compiler error: Killed (program cc1plus) ... make[3]: *** [.obj/release/qdrawhelper.o] Error 4 The workaround: Bump Travis down to using -j2 by default. Additionaly, enable --with-gui for the windows builds. This will cause configure to fail if qt is not working while also testing the config flag. Other failures which may be worth revisiting separately: - If a depends package fails, maybe remove the workdir so that it doesn't taint subsequent runs - See if there's anything repeatable about the ICE when building qt
* | | | Merge pull request #5256Pieter Wuille2014-11-125-7/+52
|\ \ \ \ | | | | | | | | | | | | | | | f4e0aef Do signature-s negation inside the tests (Pieter Wuille)
| * | | | Do signature-s negation inside the testsPieter Wuille2014-11-105-7/+52
| | | | | | | | | | | | | | | | | | | | To avoid the need for libsecp256k1 to expose such functionality.
* | | | | Merge pull request #5161Wladimir J. van der Laan2014-11-124-148/+61
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 845c86d Do not use third party services for IP detection. (Gregory Maxwell)
| * | | | | Do not use third party services for IP detection.Gregory Maxwell2014-11-074-148/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a simplified re-do of closed pull #3088. This patch eliminates the privacy and reliability problematic use of centralized web services for discovering the node's addresses for advertisement. The Bitcoin protocol already allows your peers to tell you what IP they think you have, but this data isn't trustworthy since they could lie. So the challenge is using it without creating a DOS vector. To accomplish this we adopt an approach similar to the one used by P2Pool: If we're announcing and don't have a better address discovered (e.g. via UPNP) or configured we just announce to each peer the address that peer told us. Since peers could already replace, forge, or drop our address messages this cannot create a new vulnerability... but if even one of our peers is giving us a good address we'll eventually make a useful advertisement. We also may randomly use the peer-provided address for the daily rebroadcast even if we otherwise have a seemingly routable address, just in case we've been misconfigured (e.g. by UPNP). To avoid privacy problems, we only do these things if discovery is enabled.
* | | | | | Merge pull request #5240Wladimir J. van der Laan2014-11-121-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | 5e2dcae gather_inputs: use correct variable in error message (dexX7)
| * | | | | | gather_inputs: use correct variable in error messagedexX72014-11-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | "amount" and "fee" do not exist (anymore?).
* | | | | | | Merge pull request #5245Wladimir J. van der Laan2014-11-104-5/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | d52f072 Don't show wallet options in the preferences menu when running with -disablewallet (sinetek)
| * | | | | | | Don't show wallet options in the preferences menu when running with ↵sinetek2014-11-104-5/+11
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | -disablewallet
* | | | | | | Merge pull request #5246Wladimir J. van der Laan2014-11-101-0/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | a8a5e01 Adding license. (sinetek)
| * | | | | | | Adding license.sinetek2014-11-081-0/+4
| | | | | | | |
* | | | | | | | Merge pull request #5239Wladimir J. van der Laan2014-11-103-8/+5
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | | | | | | | | | 65e3a1e Make sure that GetRandomBytes never fails (Wladimir J. van der Laan)
| * | | | | | | Make sure that GetRandomBytes never failsWladimir J. van der Laan2014-11-073-8/+5
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're using GetRandomBytes in several contexts where it's either unwieldy to return an error, or an error would mean a fatal exception anyhow. @gmaxwell checked OpenSSL a while ago and discovered that it never actually fails, but it can't hurt to be a bit paranoid here.
* | | | | | | Merge pull request #5249Pieter Wuille2014-11-101-2/+2
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | | | | | | | | 38c62ae Adding const. (sinetek)
| * | | | | | Adding const.sinetek2014-11-081-2/+2
| | |/ / / / | |/| | | |
* | | | | | Merge pull request #5210Pieter Wuille2014-11-082-5/+5
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | 1f84793 Avoid a bunch of copying/conversion in script/sign (Pieter Wuille)
| * | | | | Avoid a bunch of copying/conversion in script/signPieter Wuille2014-11-042-5/+5
| | |/ / / | |/| | |
* | | | | Merge pull request #5225Wladimir J. van der Laan2014-11-072-18/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 369be58 doc: Correct several typos in bootstrap.md (sandakersmann)
| * | | | | doc: Correct several typos in bootstrap.mdsandakersmann2014-11-072-18/+8
| | | | | | | | | | | | | | | | | | | | | | | | - Also remove references to the blockchain size
* | | | | | Merge pull request #5232Wladimir J. van der Laan2014-11-071-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | 5985ba9 Fixing warning C4099: 'CExtPubKey' : type name first seen using 'class' now seen using 'struct' (ENikS)
| * | | | | | Fixing warning C4099: 'CExtPubKey' : type name first seen using 'class' now ↵ENikS2014-11-061-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | seen using 'struct'
* | | | | | Merge pull request #5214Wladimir J. van der Laan2014-11-061-38/+29
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | eefb766 Rearrange initial config checks: AC, AM, compiler, libtool. Removed some repeated and unused prog checks. (kiwigb)
| * | | | | Rearrange initial config checks: AC, AM, compiler, libtool.kiwigb2014-11-061-38/+29
| | | | | | | | | | | | | | | | | | | | | | | | Removed some repeated and unused prog checks.
* | | | | | Merge pull request #5223Pieter Wuille2014-11-061-4/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | bfe029f Reduce bitcoin-tx dependencies (Pieter Wuille)
| * | | | | | Reduce bitcoin-tx dependenciesPieter Wuille2014-11-061-4/+2
| | | | | | |
* | | | | | | Merge pull request #5213Wladimir J. van der Laan2014-11-061-0/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | 0246ab6 depends: boost: hard-code hidden symbol visibility (Cory Fields)
| * | | | | | depends: boost: hard-code hidden symbol visibilityCory Fields2014-11-051-0/+1
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tl;dr: This solves boost visibility problems for default/release build configs on non-Linux platforms. When Bitcoin builds against boost's header-only classes, it ends up with objects containing symbols that the upstream boost libs also have. Since Bitcoin builds by default with hidden symbol visibility, it can end up trying to link against a copy of the same symbols with default visibility. This is not a problem on Linux because 3rd party static libs are un-exported by default (--exclude-libs,ALL), but that is not available for MinGW and OSX. Those platforms (and maybe others?) end up confused about which version to use. The OSX linker spews hundreds of: "ld: warning: direct access in <foo> to global weak symbol guard variable for <bar> means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings." MinGW's linker complains similarly. Since the default symbol visibility for Bitcoin is hidden and releases are built that way as well, build Boost with hidden visibility. Linux builds Boost this way also, but only for the sake of continuity. This means that the linker confusion logic is reversed, so the problem will will now be encountered if Bitcoin is built with --disable-reduce-exports, but that's better than the current situation.
* | | | | | Merge pull request #5221Pieter Wuille2014-11-062-5/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | 93a6022 Reduce bitcoin-cli dependencies (Pieter Wuille)
| * | | | | | Reduce bitcoin-cli dependenciesPieter Wuille2014-11-052-5/+1
| | |_|/ / / | |/| | | |
* | | | | | Change -genproclimit default to 1Wladimir J. van der Laan2014-11-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is less surprising. Avoids the overload-the-CPU default of using N threads for script verification as well as N threads for generation where N is number of cores.
* | | | | | Always log number of threads for script verificationWladimir J. van der Laan2014-11-061-1/+1
|/ / / / / | | | | | | | | | | | | | | | Helps for troubleshooting.
* | | | | Merge pull request #5215Wladimir J. van der Laan2014-11-051-3/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 93a3f0e Qt: Network-Traffic-Graph: make some distance between line and text (Jonas Schnelli)
| * | | | | Qt: Network-Traffic-Graph: make some distance between line and textJonas Schnelli2014-11-051-3/+5
| |/ / / / | | | | | | | | | | | | | | | Text directly glued on the graph-line looks not so good.
* | | | | Merge pull request #5218Wladimir J. van der Laan2014-11-051-1/+1
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | 236d96e Qt: Add support for missing scrollbar in peers table (Jonas Schnelli)
| * | | | Qt: Add support for missing scrollbar in peers tableJonas Schnelli2014-11-051-1/+1
| |/ / /
* | | | Merge pull request #5173Wladimir J. van der Laan2014-11-051-3/+7
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | 50b43fd Be a bit more verbose during -loadblock if we already have blocks (Matt Corallo) 8375e22 Fix -loadblock after shutdown during IBD (Matt Corallo) 4ead850 Fix for crash during block download (Matt Corallo)
| * | | Be a bit more verbose during -loadblock if we already have blocksMatt Corallo2014-10-291-0/+2
| | | |
| * | | Fix -loadblock after shutdown during IBDMatt Corallo2014-10-291-1/+1
| | | |
| * | | Fix for crash during block downloadMatt Corallo2014-10-291-2/+4
| | | |
* | | | Merge pull request #5007Wladimir J. van der Laan2014-11-046-32/+110
|\ \ \ \ | | | | | | | | | | | | | | | af82884 Add "warmup mode" for RPC server. (Daniel Kraft)