aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add README for verify-commitsPeter Todd2016-06-091-0/+26
|
* Remove keys that are no longer used for mergingPeter Todd2016-05-212-4/+1
| | | | Also updated trusted git root to be right after gmaxwell's last merge.
* Remove pointless warningPeter Todd2016-05-211-3/+0
| | | | | | | | Any attacker who managed to make an evil commit that changed something in the contrib/verify-commits/ directory could just as easily remove the warning and/or modify it to not display the evil commits; telling the user to check those commits specifically misleads them into checking just those commits rather than the script itself.
* Make verify-commits path-independentMatt Corallo2016-05-211-0/+1
|
* Make verify-commits POSIX-compliantMatt Corallo2016-05-212-14/+11
|
* Merge #8070: Remove non-determinism which is breaking net_tests #8069Wladimir J. van der Laan2016-05-191-1/+10
|\ | | | | | | | | 2a8b358 Fix typo adddrman to addrman as requested in #8070 (Ethan Heilman) f4119c6 Remove non-determinism which is breaking net_tests #8069 (EthanHeilman)
| * Fix typo adddrman to addrman as requested in #8070Ethan Heilman2016-05-181-1/+1
| |
| * Remove non-determinism which is breaking net_tests #8069EthanHeilman2016-05-181-0/+9
| |
* | Merge #8033: Fix Socks5() connect failures to be less noisy and less ↵Wladimir J. van der Laan2016-05-191-15/+22
|\ \ | |/ |/| | | | | | | | | | | | | unnecessarily scary bf9266e Use Socks5ErrorString() to decode error responses from socks proxy. (Warren Togami) 94fd1d8 Make Socks5() InterruptibleRecv() timeout/failures informative. (Warren Togami) 0d9af79 SOCKS5 connecting and connected messages with -debug=net. (Warren Togami) 00678bd Make failures to connect via Socks5() more informative and less unnecessarily scary. (Warren Togami)
| * Use Socks5ErrorString() to decode error responses from socks proxy.Warren Togami2016-05-191-12/+16
| |
| * Make Socks5() InterruptibleRecv() timeout/failures informative.Warren Togami2016-05-171-1/+2
| | | | | | | | | | | | | | | | Before: 2016-05-16 06:10:45 ERROR: Error reading proxy response After: 2016-05-16 06:10:45 Socks5() connect to k7s5d6jqig4ej4v4.onion:18333 failed: InterruptibleRecv() timeout or other failure
| * SOCKS5 connecting and connected messages with -debug=net.Warren Togami2016-05-091-2/+2
| | | | | | | | They were too noisy and not necessary for normal operation.
| * Make failures to connect via Socks5() more informative and less ↵Warren Togami2016-05-091-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | unnecessarily scary. * The "ERROR" was printed far too often during normal operation for what was not an error. * Makes the Socks5() connect failure similar to the IP connect failure in debug.log. Before: `2016-05-09 00:15:00 ERROR: Proxy error: host unreachable` After: `2016-05-09 00:15:00 Socks5() connect to t6xj6wilh4ytvcs7.onion:18333 failed: host unreachable"`
* | Merge #7917: Optimize reindexWladimir J. van der Laan2016-05-1812-49/+130
|\ \ | | | | | | | | | | | | | | | | | | | | | b4d24e1 Report reindexing progress in GUI (Pieter Wuille) d3d7547 Add -reindex-chainstate that does not rebuild block index (Pieter Wuille) fb8fad1 Optimize ActivateBestChain for long chains (Pieter Wuille) 316623f Switch reindexing to AcceptBlock in-loop and ActivateBestChain afterwards (Pieter Wuille) d253ec4 Make ProcessNewBlock dbp const and update comment (Pieter Wuille)
| * | Report reindexing progress in GUIPieter Wuille2016-05-1710-19/+82
| | |
| * | Add -reindex-chainstate that does not rebuild block indexPieter Wuille2016-05-172-7/+16
| | |
| * | Optimize ActivateBestChain for long chainsPieter Wuille2016-05-171-4/+10
| | |
| * | Switch reindexing to AcceptBlock in-loop and ActivateBestChain afterwardsPieter Wuille2016-05-172-15/+18
| | |
| * | Make ProcessNewBlock dbp const and update commentPieter Wuille2016-05-172-4/+4
| | |
* | | Merge #8054: net: Avoid duplicate getheaders requests.Wladimir J. van der Laan2016-05-181-1/+8
|\ \ \ | | | | | | | | | | | | f93c2a1 net: Avoid duplicate getheaders requests. (Daniel Kraft)
| * | | net: Avoid duplicate getheaders requests.Daniel Kraft2016-05-151-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current logic for syncing headers may lead to lots of duplicate getheaders requests being sent: If a new block arrives while the node is in headers sync, it will send getheaders in response to the block announcement. When the headers arrive, the message will be of maximum size and so a follow-up request will be sent---all of that in addition to the existing headers syncing. This will create a second "chain" of getheaders requests. If more blocks arrive, this may even lead to arbitrarily many parallel chains of redundant requests. This patch changes the behaviour to only request more headers after a maximum-sized message when it contained at least one unknown header. This avoids sustaining parallel chains of redundant requests. Note that this patch avoids the issues raised in the discussion of https://github.com/bitcoin/bitcoin/pull/6821: There is no risk of the node being permanently blocked. At the latest when a new block arrives this will trigger a new getheaders request and restart syncing.
* | | | Merge #8048: doc: Remove outdated qt4 install information from README.mdWladimir J. van der Laan2016-05-181-8/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | 6075bc4 doc: 32 and 64 bit packages are seperate (Wladimir J. van der Laan) e5764e6 doc: Remove outdated qt4 install information from README.md (Wladimir J. van der Laan)
| * | | | doc: 32 and 64 bit packages are seperateWladimir J. van der Laan2016-05-181-2/+2
| | | | |
| * | | | doc: Remove outdated qt4 install information from README.mdWladimir J. van der Laan2016-05-121-6/+0
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | This text is aimed at users installing the binaries. Now that Qt5 is linked statically, there is no need to install Qt as a run-time dependency.
* | | | Merge #7906: net: prerequisites for p2p encapsulation changesWladimir J. van der Laan2016-05-184-146/+117
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5d5e7a0 net: No need to export ConnectNode (Cory Fields) e9ed620 net: No need to export DumpBanlist (Cory Fields) 8b8f877 net: make Ban/Unban/ClearBan functionality consistent (Cory Fields) cca221f net: Drop CNodeRef for AttemptToEvictConnection (Cory Fields) 563f375 net: use the exposed GetNodeSignals() rather than g_signals directly (Cory Fields) 9faa490 net: remove unused set (Cory Fields) 52cbce2 net: don't import std namespace (Cory Fields)
| * | | | net: No need to export ConnectNodeCory Fields2016-05-101-1/+0
| | | | |
| * | | | net: No need to export DumpBanlistCory Fields2016-05-102-22/+20
| | | | |
| * | | | net: make Ban/Unban/ClearBan functionality consistentCory Fields2016-05-103-26/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Ban/Unban/ClearBan call uiInterface.BannedListChanged() as necessary - Ban/Unban/ClearBan sync to disk if the operation is user-invoked - Mark node for disconnection automatically when banning - Lock cs_vNodes while setting disconnected - Don't spin in a tight loop while setting disconnected
| * | | | net: Drop CNodeRef for AttemptToEvictConnectionCory Fields2016-05-051-53/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Locking for each operation here is unnecessary, and solves the wrong problem. Additionally, it introduces a problem when cs_vNodes is held in an owning class, to which invididual CNodeRefs won't have access. These should be weak pointers anyway, once vNodes contain shared pointers. Rather than using a refcounting class, use a 3-step process instead. 1. Lock vNodes long enough to snapshot the fields necessary for comparing 2. Unlock and do the comparison 3. Re-lock and mark the resulting node for disconnection if it still exists
| * | | | net: use the exposed GetNodeSignals() rather than g_signals directlyCory Fields2016-05-051-3/+3
| | | | |
| * | | | net: remove unused setCory Fields2016-05-051-10/+0
| | | | |
| * | | | net: don't import std namespaceCory Fields2016-05-051-32/+31
| | | | | | | | | | | | | | | | | | | | | | | | | This file is about to be broken up into chunks and moved around. Drop the namespace now rather than requiring other files to use it.
* | | | | Merge #7932: CAddrMan::Deserialize handle corrupt serializations better.Wladimir J. van der Laan2016-05-181-0/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | fb26bf0 CAddrMan::Deserialize handle corrupt serializations better. (Patrick Strateman)
| * | | | | CAddrMan::Deserialize handle corrupt serializations better.Patrick Strateman2016-04-241-0/+8
| | | | | |
* | | | | | Merge #8031: improvement to readabilityWladimir J. van der Laan2016-05-181-2/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | fe80102 changing "(tests are) automatically run" to correspond to the earlier instance of "run automatically (on the build server)" (Matthew English)
| * | | | | | changing "(tests are) automatically run" to correspond to the earlier ↵Matthew English2016-05-091-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | instance of "run automatically (on the build server)"
* | | | | | | Merge #8020: Use SipHash-2-4 for various non-cryptographic hashesWladimir J. van der Laan2016-05-189-88/+166
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a68ec21 Use SipHash-2-4 for address relay selection (Pieter Wuille) 8cc9cfe Switch CTxMempool::mapTx to use a hash index for txids (Pieter Wuille) 382c871 Use SipHash-2-4 for CCoinsCache index (Pieter Wuille) 0b1295b Add SipHash-2-4 primitives to hash (Pieter Wuille)
| * | | | | | | Use SipHash-2-4 for address relay selectionPieter Wuille2016-05-171-11/+9
| | | | | | | |
| * | | | | | | Switch CTxMempool::mapTx to use a hash index for txidsPieter Wuille2016-05-171-1/+2
| | | | | | | |
| * | | | | | | Use SipHash-2-4 for CCoinsCache indexPieter Wuille2016-05-174-76/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is ~1.7x slower than the Lookup3-of-Xor-with-salt construct we were using before, but it is a primitive designed for exactly this.
| * | | | | | | Add SipHash-2-4 primitives to hashPieter Wuille2016-05-174-0/+142
| | | | | | | |
* | | | | | | | Merge #7696: Fix de-serialization bug where AddrMan is left corruptedPieter Wuille2016-05-174-0/+146
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 1475ecf Fix de-serialization bug where AddrMan is corrupted after exception * CAddrDB modified so that when de-serialization code throws an exception Addrman is reset to a clean state * CAddrDB modified to make unit tests possible * Regression test created to ensure bug is fixed * StartNode modifed to clear adrman if CAddrDB::Read returns an error code. (EthanHeilman)
| * | | | | | | | Fix de-serialization bug where AddrMan is corrupted after exceptionEthanHeilman2016-05-044-0/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * CAddrDB modified so that when de-serialization code throws an exception Addrman is reset to a clean state * CAddrDB modified to make unit tests possible * Regression test created to ensure bug is fixed * StartNode modifed to clear adrman if CAddrDB::Read returns an error code.
* | | | | | | | | Merge #8038: [qa, doc] Various minor fixesMarcoFalke2016-05-174-8/+9
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fa83a5d [qa] wallet: Temporarily disable salvagewallet test (MarcoFalke) fadd048 [doc] Link to clang-format in the developer notes (MarcoFalke) fa72f7d [doc] Remove outdated line from listunspent RPC help, fix typo (MarcoFalke) ac40ed7 Increase timeout waiting for pruned blk00000.dat (error10)
| * | | | | | | | [qa] wallet: Temporarily disable salvagewallet testMarcoFalke2016-05-101-3/+4
| | | | | | | | |
| * | | | | | | | [doc] Link to clang-format in the developer notesMarcoFalke2016-05-101-1/+3
| | | | | | | | |
| * | | | | | | | [doc] Remove outdated line from listunspent RPC help, fix typoMarcoFalke2016-05-101-3/+1
| | | | | | | | |
| * | | | | | | | Increase timeout waiting for pruned blk00000.daterror102016-05-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In my ever-growing list of test failures, I was seeing this one intermittently. ``` Running 2nd level testscript pruning.py... Initializing test directory /tmp/testY5ypCv Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours) Mining a big blockchain of 995 blocks Check that we haven't started pruning yet because we're below PruneAfterHeight Success Though we're already using more than 550MB, current usage: 587 Mining 25 more blocks should cause the first block file to be pruned Assertion failed: blk00000.dat not pruned when it should be File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/test_framework/test_framework.py", line 118, in main self.run_test() File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 272, in run_test self.test_height_min() File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 94, in test_height_min raise AssertionError("blk00000.dat not pruned when it should be") Stopping nodes Failed ``` After digging into the test, I found that the code is waiting 10 seconds for blk00000.dat to be deleted, and then throwing this failure if it still exists after 10 seconds. I increased this amount, had the script print the actual time taken, and ran the test a few more times. The time taken ranged between 8 to 12 seconds. So, I feel that this timeout is too short. After changing the timeout to 30 seconds, the test passes consistently. (cherry picked from commit 3469911c89a48dd2fefe4d1c2a0c176256e14ee0)
* | | | | | | | | Merge #7994: Add op csv tests to script_tests.jsonPieter Wuille2016-05-171-1/+10
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | 10e83d7 Adding basic tests for OP_CSV inside of script_tests.json (Chris Stewart)
| * | | | | | | | Adding basic tests for OP_CSV inside of script_tests.jsonChris Stewart2016-05-111-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changing NOP3 op name to OP_CHECKSEQUENCEVERIFY, renaming instances of OP_NOP3 in script_tests.json to CHECKSEQUENCEVERIFY Cleaning up NOP3 comment Re-adding test cases that were accidentally deleted, removing dupicated test case, fixing formatting Removing re-labeling of OP_NOP3 to OP_CSV Fixing whitespace issues