| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
Remove "nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()" check from
importmulti, which is always true because nLowestTimestamp is set to the
minimum of the most recent block time and all the imported key timestamps,
which is necessarily lower than the maximum block time.
Github-Pull: #9760
Rebased-From: ec1267f13b7d0b9b5058c6821cf8dbf74e02d17c
|
| |
|
|
|
|
|
| |
They're unused and produce nasty deprecation warnings
Github-Pull: #9786
Rebased-From: 3301587dc5c7937141282f3799592d1e398495fb
|
| |
|
|
|
| |
Github-Pull: #9785
Rebased-From: c801c82e253dc4956069b6110f65b43f538dd5a1
|
| |
|
|
|
| |
Github-Pull: #9785
Rebased-From: 914fad155d9fc76b42b3a0414dd14b5ebc36062f
|
| |\
| |
| |
| | |
1577f07 Restore removed release notes. (Gregory Maxwell)
|
| | | |
|
| |/ |
|
| |
|
|
|
| |
Generated from git, so there may be duplicate authors
if someone used multiple mail addresses.
|
| |\
| |
| |
| | |
42f5f21 release: bump gitian descriptors for a new 0.14 package cache (Cory Fields)
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
e662af3 Use 2 hour grace period for key timestamps in importmulti rescans (Russell Yanofsky)
38d3e9e [qa] Extend import-rescan.py to test imports on pruned nodes. (Russell Yanofsky)
c28583d [qa] Extend import-rescan.py to test specific key timestamps (Russell Yanofsky)
8be0866 [qa] Simplify import-rescan.py (Russell Yanofsky)
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Gregory Maxwell <[email protected]> pointed out the lack of grace period in
https://github.com/bitcoin/bitcoin/pull/9490#issue-199407998.
The importwallet RPC which uses key timestamps in a similar way already has a 2
hour grace period.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Get rid of partial functions so the test can be more easily extended to add
more variants of imports with options that affect rescanning (e.g. different
key timestamps).
Also change the second half of the test to send /to/ the imported addresses,
instead of /from/ the imported addresses. The goal of this part of the test was
to confirm that the wallet would pick up new transactions after an import
regardless of whether or not a rescan happened during the import. But because
the wallet can only do this reliably for incoming transactions and not outgoing
transactions (which require the wallet to look up transaction inputs) the test
previously was less meaningful than it should have been.
|
| |\ \
| | |
| | |
| | | |
91fb506 Add two hour buffer to manual pruning (Alex Morcos)
|
| | |/ |
|
| |\ \
| | |
| | |
| | | |
3f78e46 Update nMinimumChainWork and defaultAssumeValid. (Gregory Maxwell)
|
| | |/ |
|
| |\ \
| |/
|/|
| | |
55c403b Ensure `-maxsigcachesize` is in valid range (John Newbery)
|
| | |
| |
| |
| |
| |
| |
| | |
- If the -maxsigcachesize parameter is set to zero, setup a minimum sized
sigcache (2 elements) rather than segfaulting.
- Handle maxsigcachesize being negative
- Handle maxsigcachesize being too large
|
| |\ \
| | |
| | |
| | | |
36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix spellings of GitHub
Remove unnecessary changes
Fix GitHub spelling on doc/translation_process.md
|
| |\ \ \
| | | |
| | | |
| | | | |
00e623d [Trivial] Update comments referencing main.cpp (CryptAxe)
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
07afcd6 Add missing cs_wallet lock that triggers new lock held assertion (Russell Yanofsky)
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
A new AssertLockHeld(cs_wallet) call was added in commit a58370e
"Dedup nTimeFirstKey update logic" (part of PR #9108).
The lock held assertion will fail when loading prexisting wallets files from
before the #9108 merge that have watch-only keys.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'override'" warnings
6c5427d wallet: Prevent "overrides a member function but is not marked 'override'" warnings (Wladimir J. van der Laan)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
warnings
Because it is used inconsistently at least version 5.4.0 of g++ to
complains about methods that don't use override. There is two ways to go
about this: remove override from the methods having it, or add it to the
methods missing it. I chose the second.
|
| |\ \ \ \ \ \
| |_|/ / / /
|/| | | | |
| | | | | | |
ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes a bug in AcceptBlock() in invoking CheckBlock() with incorrect
arguments, and restores a call to CheckBlock() from ProcessNewBlock()
as belt-and-suspenders.
Updates the (overspecified) tests to match behavior.
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | | |
9acf25c Return error when importmulti called with invalid address. (Russell Yanofsky)
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Lack of error checking noticed by Alex Morcos <[email protected]>
|
| |\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | | |
4b6cccc Selectively suppress deprecation warnings (Jonas Schnelli)
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
top of #9682)
a80f98b Use importmulti timestamp when importing watch only keys (Russell Yanofsky)
a58370e Dedup nTimeFirstKey update logic (Russell Yanofsky)
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When importing a watch-only address over importmulti with a specific timestamp,
the wallet's nTimeFirstKey is currently set to 1. After this change, the
provided timestamp will be used and stored as metadata associated with
watch-only key. This can improve wallet performance because it can avoid the
need to scan the entire blockchain for watch only addresses when timestamps are
provided.
Also adds timestamp to validateaddress return value (needed for tests).
Fixes #9034.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Also make nTimeFirstKey member variable private.
This is just a cleanup change, it doesn't change behavior in any significant
way.
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | | |
a47da4b Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0; (practicalswift)
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
0b4f273 Bugfix: Qt/Options: Restore persistent "restart required" notice (Luke Dashjr)
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
verack
d943491 qa: add a test to detect leaky p2p messages (Cory Fields)
8650bbb qa: Expose on-connection to mininode listeners (Matt Corallo)
5b5e4f8 qa: mininode learns when a socket connects, not its first action (Matt Corallo)
cbfc5a6 net: require a verack before responding to anything else (Cory Fields)
8502e7a net: parse reject earlier (Cory Fields)
c45b9fb net: correctly ban before the handshake is complete (Cory Fields)
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is certainly not exhaustive, but it's better than nothing. Adds checks
for:
- Any message received before sending a version
- Any message received other than version/reject before sending a verack
It also tries to goad the remote into sending a pong, address, or block
announcement.
|
| | | | | | | | |
|
| | | | | | | | |
|