aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | | | | | | | | wallet: Prevent "overrides a member function but is not marked 'override'" ↵Wladimir J. van der Laan2017-02-151-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | warnings Because it is used inconsistently at least version 5.4.0 of g++ to complains about methods that don't use override. There is two ways to go about this: remove override from the methods having it, or add it to the methods missing it. I chose the second.
| * | | | | | | | | | Merge #9765: Harden against mistakes handling invalid blocksWladimir J. van der Laan2017-02-162-7/+13
| |\ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | ba803ef Harden against mistakes handling invalid blocks (Suhas Daftuar)
| | * | | | | | | | | Harden against mistakes handling invalid blocksSuhas Daftuar2017-02-152-7/+13
| | | |_|/ / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a bug in AcceptBlock() in invoking CheckBlock() with incorrect arguments, and restores a call to CheckBlock() from ProcessNewBlock() as belt-and-suspenders. Updates the (overspecified) tests to match behavior.
| * | | | | | | | | Merge #9756: Return error when importmulti called with invalid address.Wladimir J. van der Laan2017-02-152-0/+13
| |\ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | 9acf25c Return error when importmulti called with invalid address. (Russell Yanofsky)
| | * | | | | | | | Return error when importmulti called with invalid address.Russell Yanofsky2017-02-132-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lack of error checking noticed by Alex Morcos <[email protected]>
| * | | | | | | | | Merge #9758: Selectively suppress deprecation warningsWladimir J. van der Laan2017-02-152-0/+6
| |\ \ \ \ \ \ \ \ \ | | |_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | 4b6cccc Selectively suppress deprecation warnings (Jonas Schnelli)
| | * | | | | | | | Selectively suppress deprecation warningsJonas Schnelli2017-02-142-0/+6
| | |/ / / / / / /
| * | | | | | | | Merge #9108: Use importmulti timestamp when importing watch only keys (on ↵Wladimir J. van der Laan2017-02-157-57/+130
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | top of #9682) a80f98b Use importmulti timestamp when importing watch only keys (Russell Yanofsky) a58370e Dedup nTimeFirstKey update logic (Russell Yanofsky)
| | * | | | | | | | Use importmulti timestamp when importing watch only keysRussell Yanofsky2017-02-107-35/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When importing a watch-only address over importmulti with a specific timestamp, the wallet's nTimeFirstKey is currently set to 1. After this change, the provided timestamp will be used and stored as metadata associated with watch-only key. This can improve wallet performance because it can avoid the need to scan the entire blockchain for watch only addresses when timestamps are provided. Also adds timestamp to validateaddress return value (needed for tests). Fixes #9034.
| | * | | | | | | | Dedup nTimeFirstKey update logicRussell Yanofsky2017-02-104-23/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make nTimeFirstKey member variable private. This is just a cleanup change, it doesn't change behavior in any significant way.
| * | | | | | | | | Merge #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0;Wladimir J. van der Laan2017-02-152-8/+2
| |\ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | a47da4b Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0; (practicalswift)
| | * | | | | | | | Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0;practicalswift2017-02-072-8/+2
| | | | | | | | | |
| * | | | | | | | | Merge #9755: Bugfix: Qt/Options: Restore persistent "restart required" noticeJonas Schnelli2017-02-141-1/+4
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0b4f273 Bugfix: Qt/Options: Restore persistent "restart required" notice (Luke Dashjr)
| | * | | | | | | | | Bugfix: Qt/Options: Restore persistent "restart required" noticeLuke Dashjr2017-02-131-1/+4
| | | | | | | | | | |
| * | | | | | | | | | Merge #9720: net: fix banning and disallow sending messages before receiving ↵Wladimir J. van der Laan2017-02-143-49/+214
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | verack d943491 qa: add a test to detect leaky p2p messages (Cory Fields) 8650bbb qa: Expose on-connection to mininode listeners (Matt Corallo) 5b5e4f8 qa: mininode learns when a socket connects, not its first action (Matt Corallo) cbfc5a6 net: require a verack before responding to anything else (Cory Fields) 8502e7a net: parse reject earlier (Cory Fields) c45b9fb net: correctly ban before the handshake is complete (Cory Fields)
| | * | | | | | | | | | qa: add a test to detect leaky p2p messagesCory Fields2017-02-132-0/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is certainly not exhaustive, but it's better than nothing. Adds checks for: - Any message received before sending a version - Any message received other than version/reject before sending a verack It also tries to goad the remote into sending a pong, address, or block announcement.
| | * | | | | | | | | | qa: Expose on-connection to mininode listenersMatt Corallo2017-02-131-0/+2
| | | | | | | | | | | |
| | * | | | | | | | | | qa: mininode learns when a socket connects, not its first actionMatt Corallo2017-02-131-12/+24
| | | | | | | | | | | |
| | * | | | | | | | | | net: require a verack before responding to anything elseCory Fields2017-02-131-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7a8c251901 made this logic hard to follow. After that change, messages would not be sent to a peer via SendMessages() before the handshake was complete, but messages could still be sent as a response to an incoming message. For example, if a peer had not yet sent a verack, we wouldn't notify it about new blocks, but we would respond to a PING with a PONG. This change makes the behavior straightforward: until we've received a verack, never send any message other than version/verack/reject. The behavior until a VERACK is received has always been undefined, this change just tightens our policy. This also makes testing much easier, because we can now connect but not send version/verack, and anything sent to us is an error.
| | * | | | | | | | | | net: parse reject earlierCory Fields2017-02-131-26/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this change, all messages were ignored until a VERSION message was received, as well as possibly incurring a ban score. Since REJECT messages can be sent at any time (including as a response to a bad VERSION message), make sure to always parse them. Moving this parsing up keeps it from being caught in the if (pfrom->nVersion == 0) check below.
| | * | | | | | | | | | net: correctly ban before the handshake is completeCory Fields2017-02-131-23/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7a8c251901 made a change to avoid getting into SendMessages() until the version handshake (VERSION + VERACK) is complete. That was done to avoid leaking out messages to nodes who could connect, but never bothered sending us their version/verack. Unfortunately, the ban tally and possible disconnect are done as part of SendMessages(). So after 7a8c251901, if a peer managed to do something bannable before completing the handshake (say send 100 non-version messages before their version), they wouldn't actually end up getting disconnected/banned. That's fixed here by checking the banscore as part of ProcessMessages() in addition to SendMessages().
| * | | | | | | | | | | Merge #9715: Disconnect peers which we do not receive VERACKs from within 60 secWladimir J. van der Laan2017-02-144-12/+135
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 66f861a Add a test for P2P inactivity timeouts (Matt Corallo) b436f92 qa: Expose on-connection to mininode listeners (Matt Corallo) 8aaba7a qa: mininode learns when a socket connects, not its first action (Matt Corallo) 2cbd119 Disconnect peers which we do not receive VERACKs from within 60 sec (Matt Corallo)
| | * | | | | | | | | | | Add a test for P2P inactivity timeoutsMatt Corallo2017-02-092-0/+104
| | | | | | | | | | | | |
| | * | | | | | | | | | | qa: Expose on-connection to mininode listenersMatt Corallo2017-02-081-0/+2
| | | | | | | | | | | | |
| | * | | | | | | | | | | qa: mininode learns when a socket connects, not its first actionMatt Corallo2017-02-081-12/+24
| | | | | | | | | | | | |
| | * | | | | | | | | | | Disconnect peers which we do not receive VERACKs from within 60 secMatt Corallo2017-02-071-0/+5
| | | |_|/ / / / / / / / | | |/| | | | | | | | |
| * | | | | | | | | | | Merge #9682: Require timestamps for importmulti keysWladimir J. van der Laan2017-02-144-13/+77
| |\ \ \ \ \ \ \ \ \ \ \ | | | |_|_|/ / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 266a811 Use MTP for importmulti "now" timestamps (Russell Yanofsky) 3cf9917 Add test to check new importmulti "now" value (Russell Yanofsky) 442887f Require timestamps for importmulti keys (Russell Yanofsky)
| | * | | | | | | | | | Use MTP for importmulti "now" timestampsRussell Yanofsky2017-02-102-2/+2
| | | | | | | | | | | |
| | * | | | | | | | | | Add test to check new importmulti "now" valueRussell Yanofsky2017-02-102-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Easiest way to test this was to expose the timestamp via the validateaddress RPC (which was already looking up and returning key metadata).
| | * | | | | | | | | | Require timestamps for importmulti keysRussell Yanofsky2017-02-103-9/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Additionally, accept a "now" timestamp, to allow avoiding rescans for keys which are known never to have been used. Note that the behavior when "now" is specified is slightly different than the previous behavior when no timestamp was specified at all. Previously, when no timestamp was specified, it would avoid rescanning during the importmulti call, but set the key's nCreateTime value to 1, which would not prevent future block reads in later ScanForWalletTransactions calls. With this change, passing a "now" timestamp will set the key's nCreateTime to the current block time instead of 1. Fixes #9491
| * | | | | | | | | | | Merge #9735: devtools: Handle Qt formatting characters edge-case in ↵Wladimir J. van der Laan2017-02-149-222/+1518
| |\ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | update-translations.py 7179e7c qt: Periodic translations update (Wladimir J. van der Laan) 5e903a5 devtools: Handle Qt formatting characters edge-case in update-translations.py (Wladimir J. van der Laan)
| | * | | | | | | | | | qt: Periodic translations updateWladimir J. van der Laan2017-02-108-222/+1510
| | | | | | | | | | | |
| | * | | | | | | | | | devtools: Handle Qt formatting characters edge-case in update-translations.pyWladimir J. van der Laan2017-02-101-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If both numeric format specifiers and "others" are used, assume we're dealing with a Qt-formatted message. In the case of Qt formatting (see https://doc.qt.io/qt-5/qstring.html#arg) only numeric formats are replaced at all. This means "(percentage: %1%)" is valid (which was introduced in #9461), without needing any kind of escaping that would be necessary for strprintf. Without this, this function would wrongly detect '%)' as a printf format specifier.
| * | | | | | | | | | | Merge #9736: Pre-0.14.0 hardcoded seeds updateWladimir J. van der Laan2017-02-115-1614/+2084
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a60677e Pre-0.14.0 hardcoded seeds update (Wladimir J. van der Laan) bfa9393 contrib/seeds: Update PATTERN_AGENT (Wladimir J. van der Laan) 4dfac2c Update seeds tooling to Python 3 (Wladimir J. van der Laan)
| | * | | | | | | | | | | Pre-0.14.0 hardcoded seeds updateWladimir J. van der Laan2017-02-102-1600/+2062
| | | | | | | | | | | | |
| | * | | | | | | | | | | contrib/seeds: Update PATTERN_AGENTWladimir J. van der Laan2017-02-102-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gmaxwell: Adds the newest versions, drops everything multiple softforks ago.
| | * | | | | | | | | | | Update seeds tooling to Python 3Wladimir J. van der Laan2017-02-103-13/+18
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All the other tooling scripts require Python 3, it makes sense to do so here too. Also document the dependency on python3-dnspython.
| * | | | | | | | | | | Merge #9708: Clean up all known races/platform-specific UB at the time PR ↵Pieter Wuille2017-02-103-45/+105
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | was opened db2dc7a Move CNode::addrLocal access behind locked accessors (Matt Corallo) 036073b Move CNode::addrName accesses behind locked accessors (Matt Corallo) d8f2b8a Make nTimeBestReceived atomic (Matt Corallo) 22b4966 Move [clean|str]SubVer writes/copyStats into a lock (Matt Corallo) 0f31872 Make nServices atomic (Matt Corallo) 96f42d8 Make nStartingHeight atomic (Matt Corallo) 512731b Access fRelayTxes with cs_filter lock in copyStats (Matt Corallo) ae683c1 Avoid copying CNodeStats to make helgrind OK with buggy std::string (Matt Corallo) 644f123 Make nTimeConnected const in CNode (Matt Corallo) 321d0fc net: fix a few races. Credit @TheBlueMatt (Cory Fields)
| | * | | | | | | | | | | Move CNode::addrLocal access behind locked accessorsMatt Corallo2017-02-103-7/+29
| | | | | | | | | | | | |
| | * | | | | | | | | | | Move CNode::addrName accesses behind locked accessorsMatt Corallo2017-02-103-10/+30
| | | | | | | | | | | | |
| | * | | | | | | | | | | Make nTimeBestReceived atomicMatt Corallo2017-02-101-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Move [clean|str]SubVer writes/copyStats into a lockMatt Corallo2017-02-103-4/+13
| | | | | | | | | | | | |
| | * | | | | | | | | | | Make nServices atomicMatt Corallo2017-02-101-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Make nStartingHeight atomicMatt Corallo2017-02-101-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Access fRelayTxes with cs_filter lock in copyStatsMatt Corallo2017-02-101-1/+4
| | | | | | | | | | | | |
| | * | | | | | | | | | | Avoid copying CNodeStats to make helgrind OK with buggy std::stringMatt Corallo2017-02-101-3/+2
| | | | | | | | | | | | |
| | * | | | | | | | | | | Make nTimeConnected const in CNodeMatt Corallo2017-02-102-2/+2
| | | | | | | | | | | | |
| | * | | | | | | | | | | net: fix a few races. Credit @TheBlueMattCory Fields2017-02-103-15/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are (afaik) all long-standing races or concurrent accesses. Going forward, we can clean these up so that they're not all individual atomic accesses. - Reintroduce cs_vRecv to guard receive-specific vars - Lock vRecv/vSend for CNodeStats - Make some vars atomic. - Only set the connection time in CNode's constructor so that it doesn't change
| * | | | | | | | | | | | Merge #9707: Fix RPC failure testingMarcoFalke2017-02-102-4/+21
| |\ \ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | 9db8eec Fix RPC failure testing (John Newbery)
| | * | | | | | | | | | | Fix RPC failure testingJohn Newbery2017-02-082-4/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure that RPC tests are actually checking failures correctly by: - Catching JSON RPC exceptions and verifying the error codes and messages. - Failing the test case if the JSON RPC exception isn't raised.
generated by cgit v1.2.3 (git 2.25.1) at 2026-04-28 12:18:35 +0000