aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * fixup p2p-acceptblock and mininode to test disconnectsPatrick Lodder2021-08-172-18/+31
| | | | | | | | | | | | | | | | | | | | | | without partially backporting a new testframework. - Adds a condition to NodeConn that when asyncore calls handle_read without any data, this must be a disconnect and closes the socket - Adds a little loop in the p2p-acceptblock client that waits for the socket to be in a closed state - Makes expected disconnects non-optional in p2p-acceptblock - Syncs the test descriptions and outputs with reality
| * p2p-acceptblock: add steps 8, 9 to confirm node disconnectsDakoda Greaves2021-08-171-1/+86
| |
* | Merge pull request #2441 from rnicoll/1.14.4-fees-disable-roundingPatrick Lodder2021-08-1710-11/+111
|\ \ | |/ |/| 1.14.4 fees disable rounding
| * Create feelimit.py testEd2021-08-172-0/+78
| | | | | | | | Create feelimit.py test to verify the updated fee values now rounding has been eliminated.
| * Remove relay-only roundingRoss Nicoll2021-08-178-11/+33
|/ | | | | Remove rounding of transaction sizes when calculating fee minimums for relaying, to simplify fee logic.
* Merge pull request #2457 from ReverseControl/1.14.4-suggested-changes-for-2297Patrick Lodder2021-08-171-8/+75
|\ | | | | 1.14.4 suggested changes for 2297
| * [ #2297 ] Implemented suggestions: camel casing as suggested and printing ↵Escanor Liones2021-08-161-14/+23
| | | | | | | | debug messages for invalidated blocks.
| * fix: A newly appended block header should not build on an invalid chainp-j012021-08-161-8/+66
| |
* | Merge pull request #2446 from patricklodder/1.14.4-mintxfee-testsPatrick Lodder2021-08-164-11/+100
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements, tests and assures wallet operator ease-of-sovereignty and making sure that user-defined fee logic persists through versions in the future by fixing and testing -paytxfee 1. There was an override of ANY user-defined value to CWallet::GetMinimumFee - Former logic: always override any value with either -mintxfee or -mintxrelayfee, whichever is highest - Proposed logic in this pull request: - if the user specifies a value, only override when it is lower than -mintxfee or -mintxrelayfee - this works because we set any default -mintxfee to be the same as -paytxfee, unless the user explicitly sets a -mintxfee. - if no value has been specified, use the rate from -mintxfee or -mintxrelayfee, whichever is highest 2. Test that the interaction between the wallet parameters -paytxfee and -mintxfee function as intended. This has to be done using rpc tests rather than unit tests because it tests the actual parameters passed to the executables. 3. Undoing the override exposed a misconfiguration in the bumpfee.py test, where fees were explicitly set higher, yet ignored in subsequent bumps.
| * | qa: fix bumpfee now that paytxfee worksPatrick Lodder2021-08-161-3/+4
| | |
| * | fees: remove careless override of -paytxfee in GetMinimumFeePatrick Lodder2021-08-161-8/+13
| | |
| * | qa: add -paytxfee and -mintxfee interaction testPatrick Lodder2021-08-162-0/+83
|/ / | | | | | | | | | | | | Test that the interaction between the wallet parameters -paytxfee and -mintxfee function as intended. This has to be done using rpc tests rather than unit tests because it tests the actual parameters passed to the executables.
* | Merge pull request #2456 from rnicoll/1.14.4-intellijPatrick Lodder2021-08-151-0/+6
|\ \ | | | | | | Added IntelliJ IDEA in .gitignore
| * | Added IntelliJ IDEA in .gitignore and removed dot from dogecoin.com linkJoakim Taule Kartveit2021-08-151-0/+6
|/ /
* | Merge pull request #2453 from patricklodder/1.14.4-fix-gen-seedsRoss Nicoll2021-08-151-2/+2
|\ \ | | | | | | contrib: fix generate-seeds.py to use Dogecoin p2p ports
| * | contrib: fix generate-seeds.py to use Dogecoin p2p portsPatrick Lodder2021-08-151-2/+2
| |/
* | Merge pull request #2454 from patricklodder/1.14.4-update-seedsRoss Nicoll2021-08-151-341/+127
|\ \ | | | | | | Update fixed seeds for 1.14.4
| * | update seeds for 1.14.4Patrick Lodder2021-08-151-341/+127
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | recreated seeds by selecting peers across 20+ nodes that: 1. Keep up with updates, in this case run 1.14.3 or higher 2. Have NODE_NETWORK set 3. Are not known scanning clients 4. Are connectable 5. Are stable - I ordered nodes by time they have been connected to one of my nodes resulting set is 120 good nodes for mainnet and 20 good nodes for testnet, serialized into chainparamsseeds.h using the contrib/ scripts.
* | Merge pull request #2452 from rnicoll/1.14.4-checkpointsPatrick Lodder2021-08-151-8/+9
|\ \ | | | | | | Refresh blockchain checkpoints
| * | Refresh blockchain checkpointsRoss Nicoll2021-08-151-8/+9
| | |
* | | Merge pull request #2450 from xanimo/1.14.4-txn_doublespendPatrick Lodder2021-08-142-26/+26
|\ \ \ | |/ / |/| | qa: txn_dblspend - fix arithmetic
| * | fix arithmetic; adds to standard testingDakoda Greaves2021-08-132-26/+26
| |/
* | Merge pull request #2451 from patricklodder/1.14.4-feefilter-rpcRoss Nicoll2021-08-143-0/+5
|\ \ | | | | | | rpc: add feefilter to peers from getpeerinfo
| * | rpc: add feefilter to peers from getpeerinfoPatrick Lodder2021-08-143-0/+5
| |/ | | | | | | | | | | Exposes information about the feefilter the peer sets to us, so that we can make better informed decisions when a transaction does not get relayed.
* | Merge pull request #2448 from patricklodder/1.14.4-fix-acceptblockRoss Nicoll2021-08-143-7/+7
|\ \ | | | | | | qa: fix p2p-acceptblock
| * | qa: fix p2p-acceptblockPatrick Lodder2021-08-133-7/+7
| |/ | | | | | | | | | | | | | | | | | | | | | | This test failed because the sheer number of blocks required to trigger the max length of a fork we'd keep, exceed the v4 fork height on regtest. - Adapted the blocktools.py miner to mine 0x00620004 blocks as done elsewhere too (be it suboptimal, but at least consistent) - Adapted the test to work with 1440 blocks (Dogecoin limit) instead of 288 (Bitcoin limit) - Made p2p-acceptblock a standard test instead of an extended test
* | Merge pull request #2447 from patricklodder/1.14.4-fix-qt-str-transRoss Nicoll2021-08-146-23/+23
|\ \ | |/ |/| qt: translate all user-exposed strings
| * qt: translate more user-exposed stringschromatic2021-08-145-7/+7
| |
| * fix typoPatrick Lodder2021-08-131-2/+2
| |
| * qt: translate all user-exposed stringsPatrick Lodder2021-08-112-16/+16
| |
* | Merge pull request #2437 from michilumin/1.14.4-mintxfeeRoss Nicoll2021-08-121-0/+7
|\ \ | | | | | | Adding startup logic where -paytxfee if lower than default, mintxfee is overridden
| * | Adding startup logic where -paytxfee if lower than default, implies ↵michilumin2021-08-111-0/+7
| |/ | | | | | | -mintxfee is also lowered.
* | Merge pull request #2440 from michilumin/1.14.4-fees-reduced-minimumsRoss Nicoll2021-08-127-8/+11
|\ \ | |/ |/| fees: Reduce minimum relay fee to 0.001 DOGE
| * fees: Reduce minimum relay fee to 0.001 DOGE, final change from tx to 0.01Michi Lumin2021-08-117-8/+11
|/
* Merge pull request #2439 from rnicoll/1.14.4-dust-limit-type-altRoss Nicoll2021-08-096-9/+10
|\ | | | | Use CAmount for amounts
| * Use CAmount for constant amounts tooRoss Nicoll2021-08-083-5/+5
| |
| * Use CAmount for amountsRoss Nicoll2021-08-084-4/+5
| | | | | | | | | | | | | | | | | | | | Use CAmount rather than unsigned int for amounts for consistency with other fee rate amounts. This does change the type from unsigned int to unsigned int64, and while it is unlikely anyone would need a dust limit higher than unsigned int, again this ensures the theoretical maximum is in line with other rates.
* | Merge pull request #2417 from patricklodder/1.14-serialize-getheadersPatrick Lodder2021-08-093-6/+41
|\ \ | |/ |/| Reduce getheaders spam by serializing getheader requests per peer
| * Reduce getheaders spam by serializing getheader requests per peerPatrick Lodder2021-07-223-6/+41
| | | | | | | | | | | | | | | | | | | | | | | | Introduces a counter for getheader requests that have been sent to a peer but are pending response, reducing the number of parallel requests a node pushes out to its peers when needing to sync large amounts of headers. All getheader requests are serialized during initial sync, except when a non-connecting header is received, allowing the node to resolve issues with peers sending faulty blocks using the DoS mechanism, and when we get an inv for a block that we do not know, because it's possible we're only connected to legacy nodes that do not implement header announcement properly.
* | Merge pull request #2348 from patricklodder/1.14-cfg-dust-limitRoss Nicoll2021-08-057-2/+119
|\ \ | | | | | | [fees] introduce configurable hard dust limit
| * | [fees] Express policies in COIN instead of KoinuPatrick Lodder2021-08-051-2/+2
| | |
| * | [fees] introduce configurable hard dust limitPatrick Lodder2021-08-057-1/+118
|/ / | | | | | | Co-authored-by: Ross Nicoll <[email protected]>
* | Merge pull request #2415 from rnicoll/1.14.4-rbf-feePatrick Lodder2021-08-045-43/+54
|\ \ | | | | | | Reduce BIP125 replace by fee increment value
| * | consensus: Fix a rare crash bugRoss Nicoll2021-08-041-1/+5
| | | | | | | | | | | | | | | Fix a rare crash bug where no best chain can be activated, and therefore when trying to find the height of the best chain via the last block triggers a null pointer dereference.
| * | p2p: Reduce BIP125 replace by fee increment valueMichi Lumin2021-08-044-42/+49
|/ /
* | Merge pull request #2434 from patricklodder/1.14-activatebestchain-shutdown-fixRoss Nicoll2021-08-041-3/+9
|\ \ | | | | | | bugfix: break ActivateBestChain() differently on shutdown
| * | bugfix: break ActivateBestChain() differently on shutdownPatrick Lodder2021-08-041-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | Moves the break in ActivateBestChain() when a node is being shut down from the beginning of the loop block to the end, allowing pindexNewTip to be populated with chainActive.Tip() rather than its initial NULL value. Solves issues when shutting down nodes while inside the ActivateBestChain loop.
* | | Merge pull request #2428 from zachlatta/1.14.4-nixos-build-instructionsRoss Nicoll2021-08-032-0/+40
|\ \ \ | |/ / |/| | Add build and setup instructions for NixOS
| * | Move shell.nix contents into separate fileZach Latta2021-08-032-23/+19
| | |
| * | Add build and setup instructions for NixOSZach Latta2021-07-301-0/+44
| | |