aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | Fixed typo in documentation for merkleblock.hMikerah2017-06-051-1/+1
| | | | | | | | | | | | | | | | | | | | Github-Pull: #10258 Rebased-From: dd07068d6b11e738bc954c998800b5660d160959
| | * | contrib/init/bitcoind.openrcconf: Don't disable wallet by defaultLuke Dashjr2017-06-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It's harmless if it goes unused, and confused when a wallet is desired Github-Pull: #10451 Rebased-From: afc693dea695b75721db55d0decee3b11dcb3625
| | * | [doc] Minor corrections to osx dependenciesfanquake2017-06-051-3/+3
| | | | | | | | | | | | | | | | | | | | Github-Pull: #10260 Rebased-From: 661caf83b3dcae6376e59b6cae07f0a2a4d37fe9
| | * | Fix: make CCoinsViewDbCursor::Seek work for missing keysPieter Wuille2017-06-051-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Thanks to Suhas Daftuar for figuring this out. Github-Pull: #10445 Rebased-From: 822755a424d0abfa408dc34313f4aca4b816f54f
| | * | [wallet] Securely erase potentially sensitive keys/valuesThomas Snider2017-06-052-21/+23
| | | | | | | | | | | | | | | | | | | | Github-Pull: #10308 Rebased-From: 6c914ac176624468c66febdb1ad0e24ff2118a5f
| | * | [wallet] Make sure pindex is non-null before possibly referencing in ↵Karl-Johan Alm2017-06-051-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | LogPrintf call. Github-Pull: #10265 Rebased-From: c36ea693ee16611e0337aec682d1ce80b90e1bd3
| | * | Fix some empty vector referencesPieter Wuille2017-06-051-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this. Github-Pull: #10250 Rebased-From: f478d98fe49d3c0c0f2c79b3f8d9dbfc1aafd407
| | * | Merge #10328 via branch 'debianppa-0.14' into 0.14.2_fixesLuke Dashjr2017-06-053-30/+154
| | |\ \
| | | * | Re-enable upnp support in contrib/debianMatt Corallo2017-06-033-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10328 Rebased-From: 91700aa1df57c1a9209284e743224119396604d5
| | | * | Build with QT5 on Debian-based systems using contrib/debianMatt Corallo2017-06-033-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10328 Rebased-From: c5071e1f03085b4025f2a33fb2c3079d823d660c
| | | * | Bump minimum boost version in contrib/debianMatt Corallo2017-06-032-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10328 Rebased-From: a8e928699a6ab612459e836ba24af143eae37b0f
| | | * | Update contrib/debian to latest Ubuntu PPA upload.Matt Corallo2017-06-033-28/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This: * Partially reverts 9f68ed6 (which fixed spelling in a changelog, though generally changelogs should be append-only). * Disables UPnP support (PPA has not had it for a while, and I still don't trust miniupnpc, plus it seems uneccessary - its been a while since we needed to care about Bitcoin-Qt home users getting their inbound ports auto-mapped). * Enables ZMQ. * Forces GUI to Qt4 to fix various issues people have been seeing on Ubuntu and elsewhere with Qt5. * Reverts 70899d70b (Bitcoin does not enable "instant payments", not is transaction management "carried out collectively by the network", for whatever "transaction management" means, finally Bitcoin Core is not the only way to use the Bitcoin currency, as seemingly implied in the description). Github-Pull: #10328 Rebased-From: 997021986e02f8e59024ffca6437857d9d17f396
| | * | | Merge #9497 via remote-tracking branch 'origin-pull/9497/head' into 0.14.2_fixesLuke Dashjr2017-06-053-10/+455
| | |\ \ \
| | | * | | Add CheckQueue TestsJeremy Rubin2017-02-162-0/+443
| | | | | |
| | | * | | Fix CCheckQueue IsIdle (potential) race condition and remove dangerous ↵Jeremy Rubin2017-01-201-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | constructors.
| | * | | | Merge #10008 via branch 'fee_warning-0.14' into 0.14.2_fixesLuke Dashjr2017-06-051-1/+1
| | |\ \ \ \
| | | * | | | [trivial] Fix a typo (introduced two days ago) in the default fee warningpracticalswift2017-06-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10008 Rebased-From: a3ca43bb32520fdc049bc2112a29a554188126cc
| | * | | | | Merge #9481 via remote-tracking branch 'jonas/2017/01/fee_warning' into ↵Luke Dashjr2017-06-052-0/+29
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | 0.14.2_fixes
| | | * | | | Qt/Send: Give fallback fee a reasonable indentLuke Dashjr2017-02-171-0/+2
| | | | | | |
| | | * | | | Qt/Send: Figure a decent warning colour from themeLuke Dashjr2017-02-172-3/+8
| | | | | | |
| | | * | | | [Qt] Show more significant warning if we fall back to the default feeJonas Schnelli2017-01-062-0/+22
| | | | | | |
| | * | | | | Merge #10234, #10143 (fixes only), and #9853 via branch ↵Luke Dashjr2017-06-052-50/+58
| | |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 'disconnect_ban_fixes-0.14' into 0.14.2_fixes
| | | * | | | | [tests] update disconnect_ban.py test case to work with listbannedJohn Newbery2017-06-051-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10234 Rebased-From: d6732d832aa901e733e63799260d409821a2c37a
| | | * | | | | [net] listbanned RPC and QT should show correct banned subnetsJohn Newbery2017-06-051-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10234 Rebased-From: 77c54b270dd3b469d662c8f69e06f7b00fc4136d
| | | * | | | | [tests] disconnect_ban: remove dependency on urllibJohn Newbery2017-06-051-11/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10143 Rebased-From: 5cc3ee24d29397737f2746d78b19a2509c0dedbb
| | | * | | | | [tests] disconnect_ban: use wait_until instead of sleepJohn Newbery2017-06-051-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10143 Rebased-From: 12de2f252c8f48e05c579cb679866a68af8c660e
| | | * | | | | [tests] disconnectban test - only use two nodesJohn Newbery2017-06-051-26/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10143 Rebased-From: 395561becfa612fedec74fd841cb4f28afdc23d7
| | | * | | | | [tests] fix nodehandling.py flake8 warningsJohn Newbery2017-06-051-20/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10143 Rebased-From: d6564a26f4afc28d7d1a24b94946916387c9bf24
| | * | | | | | Merge #9853 via branch 'fixerrorcodes-0.14' into 0.14.2_fixesLuke Dashjr2017-06-0512-140/+128
| | |\| | | | |
| | | * | | | | Update release notes to include RPC error code changes.John Newbery2017-06-051-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #9853 Rebased-From: adaa281da12bcc697779f97973cea6b103eec4ab
| | | * | | | | Return correct error codes in fundrawtransaction().John Newbery2017-06-053-47/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fundrawtransaction() RPC was returning misleading or incorrect error codes (for example RPC_INTERNAL_ERROR when funding the transaction failed). This commit fixes those error codes: - RPC_INTERNAL_ERROR should not be returned for application-level errors, only for genuine internal errors such as corrupted data. That error code has been replaced with RPC_WALLET_ERROR. This commit also updates the test cases to explicitly test the error code. Github-Pull: #9853 Rebased-From: dab804c18a427901684ebe936b2069a97e04a268
| | | * | | | | Return correct error codes in setban().John Newbery2017-06-052-10/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The setban() RPC was returning misleading or incorrect error codes (for example RPC_CLIENT_NODE_ALREADY_ADDED when an invalid IP address was entered). This commit fixes those error codes: - RPC_CLIENT_INVALID_IP_OR_SUBNET should be returned if the client enters an invalid IP address or subnet. This commit also updates the test cases to explicitly test the error code. This commit also adds a testcase for trying to setban on an invalid subnet. Github-Pull: #9853 Rebased-From: a012087667edb35a36f25ae06b42b1644d80e649
| | | * | | | | Return correct error codes in removeprunedfunds().John Newbery2017-06-052-14/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The removeprunedfunds() RPC was returning misleading or incorrect error codes (for example RPC_INTERNAL_ERROR when the transaction was not found in the wallet). This commit fixes those error codes: - RPC_INTERNAL_ERROR should not be returned for application-level errors, only for genuine internal errors such as corrupted data. This error code has been replaced with RPC_WALLET_ERROR. This commit also updates the test cases to explicitly test the error code. Github-Pull: #9853 Rebased-From: 960bc7f778d8dd618e65f1e37ec734e2d4734051
| | | * | | | | Return correct error codes in blockchain.cpp.John Newbery2017-06-053-47/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RPCs in blockchain.cpp were returning misleading or incorrect error codes (for example getblock() returning RPC_INTERNAL_ERROR when the block had been pruned). This commit fixes those error codes: - RPC_INTERNAL_ERROR should not be returned for application-level errors, only for genuine internal errors such as corrupted data. - RPC_METHOD_NOT_FOUND should not be returned in response to a JSON request for an existing method. Those error codes have been replaced with RPC_MISC_ERROR or RPC_INVALID_PARAMETER as appropriate. Github-Pull: #9853 Rebased-From: c1190963b388590dc0a346bf625c7e84f69cee8d
| | | * | | | | Return correct error codes in bumpfee().John Newbery2017-06-052-22/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The bumpfee() RPC was returning misleading or incorrect error codes (for example RPC_INVALID_ADDRESS_OR_KEY when the transaction was not BIP125 replacable). This commit fixes those error codes: - RPC_INVALID_ADDRESS_OR_KEY if an invalid address was provided: - Invalid change address given - RPC_INVALID_PARAMETER if a single (non-address/key) parameter is incorrect - confTarget and totalFee options should not both be set. - Invalid confTarget - Insufficient totalFee (cannot be less than required fee) - RPC_WALLET_ERROR for any other error - Transaction has descendants in the wallet - Transaction has descendants in the mempool - Transaction has been mined, or is conflicted with a mined transaction - Transaction is not BIP 125 replaceable - Transaction has already been bumped - Transaction contains inputs that don't belong to the wallet - Transaction has multiple change outputs - Transaction does not have a change output - Fee is higher than maxTxFee - New fee rate is less than the minimum fee rate - Change output is too small. This commit also updates the test cases to explicitly test the error code. Github-Pull: #9853 Rebased-From: 6d07c62322f60eb2702c6654e994fc353bcfcf8c
| | * | | | | | Merge #10196 via branch 'prioritisetx_gbtcache-0.14' into 0.14.2_fixesLuke Dashjr2017-06-053-2/+17
| | |\ \ \ \ \ \ | | | |/ / / / / | | |/| | | | |
| | | * | | | | [qa] Test prioritise_transaction / getblocktemplate interactionSuhas Daftuar2017-04-211-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Github-Pull: #10196 Rebased-From: 6a61424c9eed072ae8d79d68aac71f525c1608b5
| | | * | | | | Bugfix: PrioritiseTransaction updates the mempool tx counterSuhas Daftuar2017-04-192-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The mempool's nTransactionsUpdated is used by getblocktemplate to trigger new invocations of CreateNewBlock(). Github-Pull: #10196 Rebased-From: 909306cde3770ed7019e7b635e24cedbd9de66ce
| * | | | | | | Merge #10588: doc: Note preexisting bug in display of fee calculation in ↵Wladimir J. van der Laan2017-06-151-0/+9
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | coin control 60b967e Note preexisting bug in display of fee calculation in coin control (Alex Morcos) Tree-SHA512: 0179654d313ea10b776781617cea744757344d8b4455153540f116978a72aabdc0a3092388b9cfbe8d0348b699943a9e41082ed964e161e4f3017dcd056e77fc
| | * | | | | | | Note preexisting bug in display of fee calculation in coin controlAlex Morcos2017-06-141-0/+9
| |/ / / / / / /
| * | | | | | | doc: Fill in details about miniupnp CVE-2017-8798Wladimir J. van der Laan2017-06-071-3/+13
| | | | | | | |
| * | | | | | | doc: Update manpages for 0.14.2Wladimir J. van der Laan2017-06-064-14/+14
| | | | | | | |
| * | | | | | | qt: 0.14.2 pre-rc2 translations updateWladimir J. van der Laan2017-06-0617-156/+2596
| |/ / / / / /
| * | | | | | doc: Preliminary release notes 0.14.2Wladimir J. van der Laan2017-06-051-5/+35
| | | | | | |
| * | | | | | build: bump version to 0.14.2Wladimir J. van der Laan2017-06-025-5/+5
| | | | | | |
| * | | | | | net: only enforce the services required to connectCory Fields2017-06-011-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | also once half of all outgoing nodes have our preferred flags, require only minimal flags from the rest. Github-Pull: #10441 Rebased-From: b6fbfc228236947eaea5c14dda299f5a01810e92
| * | | | | | Merge #10484: 0.14 BackportsWladimir J. van der Laan2017-05-318-15/+54
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1847642 [Wallet] unset change position when there is no change on exact match (Gregory Sanders) ae479bc build: fix bitcoin-config.h regeneration after touching build files (Cory Fields) 3d395d6 build: remove wonky auto top-level convenience targets (Cory Fields) 4bc99c3 Add missing <atomic> header in clientmodel.h (Jonas Schnelli) 222f377 Set both time/height header caches at the same time (Jonas Schnelli) 7da1337 Declare headers height/time cache mutable, re-set the methods const (Jonas Schnelli) 9ac40e8 Update the remaining blocks left in modaloverlay at init. (Jonas Schnelli) 1e936d7 Reduce cs_main locks during modal overlay by adding an atomic cache (Jonas Schnelli) 0aee4a1 Check interruptNet during dnsseed lookups (Matt Corallo)
| | * | | | | | [Wallet] unset change position when there is no change on exact matchGregory Sanders2017-05-312-2/+8
| | | | | | | |
| | * | | | | | build: fix bitcoin-config.h regeneration after touching build filesCory Fields2017-05-311-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was a long-standing and annoying problem. If autogen.sh was not manually run after touching configure.ac, bitcoin-config.h would not be properly regenerated. This causes very subtle problems when configure appears to enable a new value, but it does not end up reflected in the build.
| | * | | | | | build: remove wonky auto top-level convenience targetsCory Fields2017-05-311-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These were meant to help build subdir targets from the top builddir, but cause infinite recursion when going the other way. If anyone actually uses these, we can add back specific targets.