diff options
| author | MarcoFalke <[email protected]> | 2019-05-08 10:03:06 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-05-08 10:06:21 -0400 |
| commit | fa52eb55c9fe3f7f8517a5804a55edb7f7b3a625 (patch) | |
| tree | 5ed0ba914b00a7c2c108626a287bc881d0499604 /test/functional/feature_nulldummy.py | |
| parent | Merge #15664: change default Python block serialization to witness (diff) | |
| download | discoin-fa52eb55c9fe3f7f8517a5804a55edb7f7b3a625.tar.xz discoin-fa52eb55c9fe3f7f8517a5804a55edb7f7b3a625.zip | |
test: Remove True argument to CBlock::serialize
Unnamed arguments are confusing as to what they mean without looking up
the function signature.
Since segwit is active by default in regtest, and all blocks are
serialized with witness (#15664, c459c5f), remove the argument
`with_witness=True` from all calls to `CBlock::serialize` and
`BlockTransactions::serialize`.
This diff has been created with a script, but is better reviewed without
a scripted diff.
sed -i --regexp-extended -e 's/block(_?[2a-z]*)\.serialize\([a-z_]*=?True/block\1.serialize(/g' $(git grep -l serialize ./test)
Diffstat (limited to 'test/functional/feature_nulldummy.py')
| -rwxr-xr-x | test/functional/feature_nulldummy.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/feature_nulldummy.py b/test/functional/feature_nulldummy.py index a56c983cc..60a703c48 100755 --- a/test/functional/feature_nulldummy.py +++ b/test/functional/feature_nulldummy.py @@ -108,7 +108,7 @@ class NULLDUMMYTest(BitcoinTestFramework): witness and add_witness_commitment(block) block.rehash() block.solve() - node.submitblock(block.serialize(True).hex()) + node.submitblock(block.serialize().hex()) if (accept): assert_equal(node.getbestblockhash(), block.hash) self.tip = block.sha256 |