diff options
| author | Matt Corallo <[email protected]> | 2019-01-23 15:14:16 -0500 |
|---|---|---|
| committer | Suhas Daftuar <[email protected]> | 2019-05-02 11:00:19 -0400 |
| commit | 7b999103e21509e1c2dec10f68e48744ffe90f55 (patch) | |
| tree | 4c602dc5527eec26313c0aeced76b691047abab6 /test/functional/data | |
| parent | [refactor] drop IsInvalid(nDoSOut) (diff) | |
| download | discoin-7b999103e21509e1c2dec10f68e48744ffe90f55.tar.xz discoin-7b999103e21509e1c2dec10f68e48744ffe90f55.zip | |
Clean up banning levels
Compared with previous bans, the following changes are made:
* Txn with empty vin/vout or null prevouts move from 10 DoS
points to 100.
* Loose transactions with a dependency loop now result in a ban
instead of 10 DoS points.
* Many pre-segwit soft-fork errors now result in a ban.
Note: Transactions that violate soft-fork script flags since P2SH do not generally
result in a ban. Also, banning behavior for invalid blocks is dependent on
whether the node is validating with multiple script check threads, due to a long-
standing bug. That inconsistency is still present after this commit.
* Proof of work failure moves from 50 DoS points to a ban.
* Blocks with timestamps under MTP now result in a ban, blocks
too far in the future continue to *not* result in a ban.
* Inclusion of non-final transactions in a block now results in a
ban instead of 10 DoS points.
Co-authored-by: Anthony Towns <[email protected]>
Diffstat (limited to 'test/functional/data')
| -rw-r--r-- | test/functional/data/invalid_txs.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/functional/data/invalid_txs.py b/test/functional/data/invalid_txs.py index 02deae92f..f0991a284 100644 --- a/test/functional/data/invalid_txs.py +++ b/test/functional/data/invalid_txs.py @@ -58,7 +58,7 @@ class BadTxTemplate: class OutputMissing(BadTxTemplate): reject_reason = "bad-txns-vout-empty" - expect_disconnect = False + expect_disconnect = True def get_tx(self): tx = CTransaction() @@ -69,7 +69,7 @@ class OutputMissing(BadTxTemplate): class InputMissing(BadTxTemplate): reject_reason = "bad-txns-vin-empty" - expect_disconnect = False + expect_disconnect = True def get_tx(self): tx = CTransaction() |