aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCory Fields <[email protected]>2018-02-01 10:29:15 -0500
committerCory Fields <[email protected]>2018-02-01 11:31:27 -0500
commit96dbd381cf0ded169406bab3b1ba911a13d563c5 (patch)
tree03d9a1dcbe0a5fcef8f18ce5f859f3e57395550a /src
parentMerge #12309: doc: Explain how to update chainTxData in release process (diff)
downloaddiscoin-96dbd381cf0ded169406bab3b1ba911a13d563c5.tar.xz
discoin-96dbd381cf0ded169406bab3b1ba911a13d563c5.zip
net: initialize socket to avoid closing random fd's
Diffstat (limited to 'src')
-rw-r--r--src/net.cpp2
-rw-r--r--src/netbase.cpp3
2 files changed, 4 insertions, 1 deletions
diff --git a/src/net.cpp b/src/net.cpp
index 811139074..f407add09 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -410,7 +410,7 @@ CNode* CConnman::ConnectNode(CAddress addrConnect, const char *pszDest, bool fCo
// Connect
bool connected = false;
- SOCKET hSocket;
+ SOCKET hSocket = INVALID_SOCKET;
proxyType proxy;
if (addrConnect.IsValid()) {
bool proxyConnectionFailed = false;
diff --git a/src/netbase.cpp b/src/netbase.cpp
index 276b2f4dc..d51277c49 100644
--- a/src/netbase.cpp
+++ b/src/netbase.cpp
@@ -682,6 +682,9 @@ bool CloseSocket(SOCKET& hSocket)
#else
int ret = close(hSocket);
#endif
+ if (ret) {
+ LogPrintf("Socket close failed: %d. Error: %s\n", hSocket, NetworkErrorString(WSAGetLastError()));
+ }
hSocket = INVALID_SOCKET;
return ret != SOCKET_ERROR;
}