diff options
| author | Pieter Wuille <[email protected]> | 2016-04-24 16:21:44 +0200 |
|---|---|---|
| committer | Pieter Wuille <[email protected]> | 2016-04-25 14:42:07 +0200 |
| commit | 5d0434d13d0145a110c0c93e59edfd7d062f8531 (patch) | |
| tree | 7a6629f4f661d2b52b8d5b2304cf42e673caf7e8 /src | |
| parent | CDataStream::ignore Throw exception instead of assert on negative nSize. (diff) | |
| download | discoin-5d0434d13d0145a110c0c93e59edfd7d062f8531.tar.xz discoin-5d0434d13d0145a110c0c93e59edfd7d062f8531.zip | |
Fix OOM bug: UTXO entries with invalid script length
Diffstat (limited to 'src')
| -rw-r--r-- | src/compressor.h | 10 | ||||
| -rw-r--r-- | src/streams.h | 14 |
2 files changed, 22 insertions, 2 deletions
diff --git a/src/compressor.h b/src/compressor.h index 4a7209083..fa702f0df 100644 --- a/src/compressor.h +++ b/src/compressor.h @@ -86,8 +86,14 @@ public: return; } nSize -= nSpecialScripts; - script.resize(nSize); - s >> REF(CFlatData(script)); + if (nSize > MAX_SCRIPT_SIZE) { + // Overly long script, replace with a short invalid one + script << OP_RETURN; + s.ignore(nSize); + } else { + script.resize(nSize); + s >> REF(CFlatData(script)); + } } }; diff --git a/src/streams.h b/src/streams.h index a50fe4e85..ed14f3f41 100644 --- a/src/streams.h +++ b/src/streams.h @@ -406,6 +406,20 @@ public: return (*this); } + CAutoFile& ignore(size_t nSize) + { + if (!file) + throw std::ios_base::failure("CAutoFile::ignore: file handle is NULL"); + unsigned char data[4096]; + while (nSize > 0) { + size_t nNow = std::min<size_t>(nSize, sizeof(data)); + if (fread(data, 1, nNow, file) != nNow) + throw std::ios_base::failure(feof(file) ? "CAutoFile::ignore: end of file" : "CAutoFile::read: fread failed"); + nSize -= nNow; + } + return (*this); + } + CAutoFile& write(const char* pch, size_t nSize) { if (!file) |