diff options
| author | Matt Corallo <[email protected]> | 2018-05-11 16:56:19 -0400 |
|---|---|---|
| committer | Matt Corallo <[email protected]> | 2018-06-05 16:41:25 -0400 |
| commit | 25bc9615b7480e4ba2c482a6f0e7e3b33f50e6e0 (patch) | |
| tree | b22e3476a3148397fa6ff7cfafe3a4da0fffd5c4 /src/validation.cpp | |
| parent | Merge #13288: rpc: Remove the need to include rpc/blockchain.cpp in order to ... (diff) | |
| download | discoin-25bc9615b7480e4ba2c482a6f0e7e3b33f50e6e0.tar.xz discoin-25bc9615b7480e4ba2c482a6f0e7e3b33f50e6e0.zip | |
Document validationinterace callback blocking deadlock potential.
Diffstat (limited to 'src/validation.cpp')
| -rw-r--r-- | src/validation.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/validation.cpp b/src/validation.cpp index 9791d6e2d..1a81cd17b 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -2704,6 +2704,9 @@ bool CChainState::ActivateBestChain(CValidationState &state, const CChainParams& // Block until the validation queue drains. This should largely // never happen in normal operation, however may happen during // reindex, causing memory blowup if we run too far ahead. + // Note that if a validationinterface callback ends up calling + // ActivateBestChain this may lead to a deadlock! We should + // probably have a DEBUG_LOCKORDER test for this in the future. SyncWithValidationInterfaceQueue(); } |