diff options
| author | MarcoFalke <[email protected]> | 2019-03-02 09:59:09 -0500 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-03-02 09:59:18 -0500 |
| commit | 789b0bbf2afcbaa5ce2b99945aa4b02866a61972 (patch) | |
| tree | 3d7ea837b88a8fae4dd96ef88106e44d499a513c /src/test | |
| parent | Merge #15338: ci: Build and run tests once on freebsd (diff) | |
| parent | Fix lack of warning of unrecognized section names (diff) | |
| download | discoin-789b0bbf2afcbaa5ce2b99945aa4b02866a61972.tar.xz discoin-789b0bbf2afcbaa5ce2b99945aa4b02866a61972.zip | |
Merge #15335: Fix lack of warning of unrecognized section names
1a7ba84e11 Fix lack of warning of unrecognized section names (Akio Nakamura)
Pull request description:
In #14708, It was introduced that to warn when unrecognized section names are exist in the config file.
But ```m_config_sections.clear()``` in ```ArgsManager::ReadConfigStream()``` is called every time when reading each configuration file, so it can warn about only last reading file if ```includeconf``` exists.
This PR fix lack of warning by collecting all section names by moving ```m_config_sections.clear()``` to ```ArgsManager::ReadConfigFiles()``` .
Also add a test code to confirm this situation.
Tree-SHA512: 26aa0cbe3e4ae2e58cbe73d4492ee5cf465fd4c3e5df2c8ca7e282b627df9e637267af1e3816386b1dc6db2398b31936925ce0e432219fec3a9b3398f01e3e65
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/util_tests.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp index 860f64bb1..e17ae7103 100644 --- a/src/test/util_tests.cpp +++ b/src/test/util_tests.cpp @@ -180,9 +180,10 @@ struct TestArgsManager : public ArgsManager { LOCK(cs_args); m_config_args.clear(); + m_config_sections.clear(); } std::string error; - BOOST_REQUIRE(ReadConfigStream(streamConfig, error)); + BOOST_REQUIRE(ReadConfigStream(streamConfig, "", error)); } void SetNetworkOnlyArg(const std::string arg) { |