diff options
| author | Wladimir J. van der Laan <[email protected]> | 2018-12-07 17:19:28 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2018-12-07 17:19:48 +0100 |
| commit | d38a2c14168d4c39530ff44cca2d7fec8668045c (patch) | |
| tree | be4b575fd92633b51b4861e5bbcbddbf7929f562 /src/test | |
| parent | Merge #14854: qt: Cleanup SplashScreen class (diff) | |
| parent | rpc: Avoid creating non-standard raw transactions (diff) | |
| download | discoin-d38a2c14168d4c39530ff44cca2d7fec8668045c.tar.xz discoin-d38a2c14168d4c39530ff44cca2d7fec8668045c.zip | |
Merge #14890: rpc: Avoid creating non-standard raw transactions
fa4c8679ed94f215ce895938f7c3c169a2ce101e rpc: Avoid creating non-standard raw transactions (MarcoFalke)
Pull request description:
Multiple OP_RETURN outputs in a transaction are not standard and unlikely to be relayed, so avoid creating them.
Apart from that, the logic was broken in that it duplicated the same hex-data for each data output: Closes #14868.
Tree-SHA512: b08d08062b5622e8a7b497e490ccaf53b06e844c863fda3bf3f932a98684a809e8341aeb98232059a795afb32d8770a6c5591a66f8e6ee372b672af245607887
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/rpc_tests.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/test/rpc_tests.cpp b/src/test/rpc_tests.cpp index 121b72a5f..ff4839892 100644 --- a/src/test/rpc_tests.cpp +++ b/src/test/rpc_tests.cpp @@ -129,9 +129,6 @@ BOOST_AUTO_TEST_CASE(rpc_createraw_op_return) { BOOST_CHECK_NO_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"data\":\"68656c6c6f776f726c64\"}")); - // Allow more than one data transaction output - BOOST_CHECK_NO_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"data\":\"68656c6c6f776f726c64\",\"data\":\"68656c6c6f776f726c64\"}")); - // Key not "data" (bad address) BOOST_CHECK_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"somedata\":\"68656c6c6f776f726c64\"}"), std::runtime_error); |