diff options
| author | MarcoFalke <[email protected]> | 2019-05-20 14:57:06 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-05-20 14:58:05 -0400 |
| commit | 2d1583ee6aff4b68dc46bcb87eb7a85f90b465c3 (patch) | |
| tree | 0800bea8905330dd8bced291b2ad38c62bb30151 /src/test/versionbits_tests.cpp | |
| parent | Merge #13998: Scripts and tools: gitian-build.py improvements and corrections (diff) | |
| parent | Make --setup command independent (diff) | |
| download | discoin-2d1583ee6aff4b68dc46bcb87eb7a85f90b465c3.tar.xz discoin-2d1583ee6aff4b68dc46bcb87eb7a85f90b465c3.zip | |
Merge #15236: scripts and tools: Make --setup command independent
e0eae1b4a4 Make --setup command independent (Hennadii Stepanov)
Pull request description:
This PR allows a user to run:
```sh
./gitian-build.py --setup
```
without unused `signer` and `version` options.
In master the `signer` and `version` options are mandatory. This implies the following code is dead:
https://github.com/bitcoin/bitcoin/blob/387eb5b34307448f16d3769ac0245c4e3d996a38/contrib/gitian-build.py#L192-L200
This PR fixes those lines of code.
Also this PR has a nice side effect: there is no more warnings about macOS build during processing `--setup` command. Ref: https://github.com/bitcoin/bitcoin/pull/13998#issuecomment-493691117
Note: https://github.com/bitcoin-core/docs/blob/master/gitian-building.md will be updated when this PR is merged.
ACKs for commit e0eae1:
Tree-SHA512: df851fe461e402229c57b410f30f1d8bc816e8a2600ece4249aa39c763566de5b661e7aa0af171d484727eb463a6d0e10cfcf459aa60ae1a5d4e12974a8615c6
Diffstat (limited to 'src/test/versionbits_tests.cpp')
0 files changed, 0 insertions, 0 deletions