diff options
| author | MarcoFalke <[email protected]> | 2018-08-27 13:32:59 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2018-08-27 13:33:04 -0400 |
| commit | dd34204611e1dd13be441e2d54c8f659e9c7a9cd (patch) | |
| tree | c2ff516614a1e43382087b9408caefc80f8f6374 /src/test/validation_block_tests.cpp | |
| parent | Merge #14023: Remove accounts rpcs (diff) | |
| parent | Mark single-argument constructors "explicit" (diff) | |
| download | discoin-dd34204611e1dd13be441e2d54c8f659e9c7a9cd.tar.xz discoin-dd34204611e1dd13be441e2d54c8f659e9c7a9cd.zip | |
Merge #13769: Mark single-argument constructors "explicit"
1ac3c983bf Mark single-argument constructors "explicit" (practicalswift)
Pull request description:
Mark single-argument constructors `explicit`.
Rationale:
* Avoid unexpected implicit promotions.
From the developer notes:
> **By default, declare single-argument constructors explicit.**
> Rationale: This is a precaution to avoid unintended conversions that might arise when single-argument constructors are used as implicit conversion functions.
Tree-SHA512: 7901ed5be808c9d0ecb5ca501e1bc0395987fe1b7941b8548cebac2ff08a14f7dab61fab374a69b9ba29a9295a04245c814325c7f95b97ae558af0780f111dfa
Diffstat (limited to 'src/test/validation_block_tests.cpp')
| -rw-r--r-- | src/test/validation_block_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/validation_block_tests.cpp b/src/test/validation_block_tests.cpp index 37c4f7913..4316f3799 100644 --- a/src/test/validation_block_tests.cpp +++ b/src/test/validation_block_tests.cpp @@ -23,7 +23,7 @@ BOOST_FIXTURE_TEST_SUITE(validation_block_tests, RegtestingSetup) struct TestSubscriber : public CValidationInterface { uint256 m_expected_tip; - TestSubscriber(uint256 tip) : m_expected_tip(tip) {} + explicit TestSubscriber(uint256 tip) : m_expected_tip(tip) {} void UpdatedBlockTip(const CBlockIndex* pindexNew, const CBlockIndex* pindexFork, bool fInitialDownload) override { |