diff options
| author | MarcoFalke <[email protected]> | 2019-06-06 16:41:24 +0200 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-06-06 16:41:40 +0200 |
| commit | d0f81a96d9c158a9226dc946bdd61d48c4d42959 (patch) | |
| tree | b3c31f70a35fe6ffcd872714afb4df6005f3df44 /src/test/txvalidationcache_tests.cpp | |
| parent | Merge #15461: [depends] update to Boost 1.70 (diff) | |
| parent | Include core_io.h from core_read.cpp (diff) | |
| download | discoin-d0f81a96d9c158a9226dc946bdd61d48c4d42959.tar.xz discoin-d0f81a96d9c158a9226dc946bdd61d48c4d42959.zip | |
Merge #16129: refactor: Remove unused includes
67f4e9c522 Include core_io.h from core_read.cpp (practicalswift)
eca9767673 Make reasoning about dependencies easier by not including unused dependencies (practicalswift)
Pull request description:
Make reasoning about dependencies easier by not including unused dependencies.
Please note that the removed headers are _not_ "transitively included" by other still included headers. Thus the removals are real.
As an added bonus this change means less work for the preprocessor/compiler. At least 51 393 lines of code no longer needs to be processed:
```
$ git diff -u HEAD~1 | grep -E '^\-#include ' | cut -f2 -d"<" | cut -f1 -d">" | \
sed 's%^%src/%g' | xargs cat | wc -l
51393
```
Note that 51 393 is the lower bound: the real number is likely much higher when taking into account transitively included headers :-)
ACKs for commit 67f4e9:
Tree-SHA512: 0c8868aac59813f099ce53d5307eed7962dd6f2ff3546768ef9e5c4508b87f8210f1a22c7e826c3c06bebbf28bdbfcf1628ed354c2d0fdb9a31a42cefb8fdf13
Diffstat (limited to 'src/test/txvalidationcache_tests.cpp')
| -rw-r--r-- | src/test/txvalidationcache_tests.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/test/txvalidationcache_tests.cpp b/src/test/txvalidationcache_tests.cpp index fe30d5f3a..352ce0295 100644 --- a/src/test/txvalidationcache_tests.cpp +++ b/src/test/txvalidationcache_tests.cpp @@ -13,9 +13,7 @@ #include <script/sign.h> #include <test/setup_common.h> #include <util/time.h> -#include <core_io.h> #include <keystore.h> -#include <policy/policy.h> #include <boost/test/unit_test.hpp> |