diff options
| author | Calvin Kim <[email protected]> | 2020-05-18 17:14:10 +0900 |
|---|---|---|
| committer | Calvin Kim <[email protected]> | 2020-05-22 01:40:31 +0900 |
| commit | c57f03ce1741b38af448bec7b22ab9f8ac21f067 (patch) | |
| tree | fc53ee2ad75995ae01f998dca70574754ee91f7b /src/test/script_tests.cpp | |
| parent | Merge #18938: tests: Fill fuzzing coverage gaps for functions in consensus/va... (diff) | |
| download | discoin-c57f03ce1741b38af448bec7b22ab9f8ac21f067.tar.xz discoin-c57f03ce1741b38af448bec7b22ab9f8ac21f067.zip | |
refactor: Replace const char* to std::string
Some functions should be returning std::string instead of const char*.
This commit changes that.
Diffstat (limited to 'src/test/script_tests.cpp')
| -rw-r--r-- | src/test/script_tests.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/script_tests.cpp b/src/test/script_tests.cpp index 56454f61f..cb3ae290d 100644 --- a/src/test/script_tests.cpp +++ b/src/test/script_tests.cpp @@ -102,7 +102,7 @@ static ScriptErrorDesc script_errors[]={ {SCRIPT_ERR_SIG_FINDANDDELETE, "SIG_FINDANDDELETE"}, }; -static const char *FormatScriptError(ScriptError_t err) +static std::string FormatScriptError(ScriptError_t err) { for (unsigned int i=0; i<ARRAYLEN(script_errors); ++i) if (script_errors[i].err == err) @@ -134,7 +134,7 @@ void DoTest(const CScript& scriptPubKey, const CScript& scriptSig, const CScript CMutableTransaction tx = BuildSpendingTransaction(scriptSig, scriptWitness, txCredit); CMutableTransaction tx2 = tx; BOOST_CHECK_MESSAGE(VerifyScript(scriptSig, scriptPubKey, &scriptWitness, flags, MutableTransactionSignatureChecker(&tx, 0, txCredit.vout[0].nValue), &err) == expect, message); - BOOST_CHECK_MESSAGE(err == scriptError, std::string(FormatScriptError(err)) + " where " + std::string(FormatScriptError((ScriptError_t)scriptError)) + " expected: " + message); + BOOST_CHECK_MESSAGE(err == scriptError, FormatScriptError(err) + " where " + FormatScriptError((ScriptError_t)scriptError) + " expected: " + message); // Verify that removing flags from a passing test or adding flags to a failing test does not change the result. for (int i = 0; i < 16; ++i) { |