diff options
| author | fanquake <[email protected]> | 2020-07-22 15:28:27 +0800 |
|---|---|---|
| committer | fanquake <[email protected]> | 2020-07-22 17:32:36 +0800 |
| commit | 597d2f905ecab4fe2c64bba13f8e76e0075b2f9f (patch) | |
| tree | ba3680f507881282b94c6802a155da824a6e2fd9 /src/test/fuzz/scriptnum_ops.cpp | |
| parent | Merge #18907: walletdb: Don't remove database transaction logs and instead error (diff) | |
| parent | fuzz: add missing overrides to signature_checker (diff) | |
| download | discoin-597d2f905ecab4fe2c64bba13f8e76e0075b2f9f.tar.xz discoin-597d2f905ecab4fe2c64bba13f8e76e0075b2f9f.zip | |
Merge #19548: fuzz: add missing overrides to signature_checker
c0f09c2c9deaec4cfb35ea587363e6301dd17b88 fuzz: add missing overrides to signature_checker (Jon Atack)
Pull request description:
These functions in `fuzz/signature_checker.cpp` override virtual member functions and should be marked `override` instead of `virtual`, which is for introducing a new virtual function. The overridden virtual functions are in `script/interpreter.h:151/156/161`.
Also, per MarcoFalke suggestion, add missing parentheses in `fuzz/scriptnum_ops.cpp` and remove useless `unsigned int >= 0` conditional in `fuzz/script.cpp`.
These changes fix 5 compile warnings in gcc 10 and 3 in clang 11/12.
ACKs for top commit:
vasild:
ACK c0f09c2
MarcoFalke:
review ACK c0f09c2c9deaec4cfb35ea587363e6301dd17b88
Tree-SHA512: 76ce73ec577c1f23cf8646c31d44dcd6c6303732c47187d041a8921d0d24a50163989a375352ebc221abf2ac337bc0902149be46b6f9eebc071d2f364c407f71
Diffstat (limited to 'src/test/fuzz/scriptnum_ops.cpp')
| -rw-r--r-- | src/test/fuzz/scriptnum_ops.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/fuzz/scriptnum_ops.cpp b/src/test/fuzz/scriptnum_ops.cpp index f4e079fb8..68c1ae58c 100644 --- a/src/test/fuzz/scriptnum_ops.cpp +++ b/src/test/fuzz/scriptnum_ops.cpp @@ -33,7 +33,7 @@ void test_one_input(const std::vector<uint8_t>& buffer) case 0: { const int64_t i = fuzzed_data_provider.ConsumeIntegral<int64_t>(); assert((script_num == i) != (script_num != i)); - assert((script_num <= i) != script_num > i); + assert((script_num <= i) != (script_num > i)); assert((script_num >= i) != (script_num < i)); // Avoid signed integer overflow: // script/script.h:264:93: runtime error: signed integer overflow: -2261405121394637306 + -9223372036854775802 cannot be represented in type 'long' |