diff options
| author | Wladimir J. van der Laan <[email protected]> | 2017-08-17 22:59:56 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2017-08-18 09:01:16 +0200 |
| commit | 4afb5aa9e173991548be3627c6df258368d95ff3 (patch) | |
| tree | 8d8523dd68167f9a6299dd92cc9dd5e0fd162b23 /src/test/dbwrapper_tests.cpp | |
| parent | Merge #10901: Fix constness of ArgsManager methods (diff) | |
| parent | Declare single-argument (non-converting) constructors "explicit" (diff) | |
| download | discoin-4afb5aa9e173991548be3627c6df258368d95ff3.tar.xz discoin-4afb5aa9e173991548be3627c6df258368d95ff3.zip | |
Merge #10969: Declare single-argument (non-converting) constructors "explicit"
64fb0ac Declare single-argument (non-converting) constructors "explicit" (practicalswift)
Pull request description:
Declare single-argument (non-converting) constructors `explicit`.
In order to avoid unintended implicit conversions.
For a more thorough discussion, see ["C.46: By default, declare single-argument constructors explicit"](http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit) in the C++ Core Guidelines (Stroustrup & Sutter).
Tree-SHA512: e0c6922e56b11fa402621a38656d8b1122d16dd8f160e78626385373cf184ac7f26cb4c1851eca47e9b0dbd5e924e39a85c3cbdcb627a05ee3a655ecf5f7a0f1
Diffstat (limited to 'src/test/dbwrapper_tests.cpp')
| -rw-r--r-- | src/test/dbwrapper_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/dbwrapper_tests.cpp b/src/test/dbwrapper_tests.cpp index 6ed6e7744..251d5a714 100644 --- a/src/test/dbwrapper_tests.cpp +++ b/src/test/dbwrapper_tests.cpp @@ -231,7 +231,7 @@ struct StringContentsSerializer { // This is a terrible idea std::string str; StringContentsSerializer() {} - StringContentsSerializer(const std::string& inp) : str(inp) {} + explicit StringContentsSerializer(const std::string& inp) : str(inp) {} StringContentsSerializer& operator+=(const std::string& s) { str += s; |