diff options
| author | MarcoFalke <[email protected]> | 2019-10-16 17:33:48 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-10-16 17:33:57 -0400 |
| commit | 46d6930f8c7ba7cbcd7d86dd5d0117642fcbc819 (patch) | |
| tree | 54a001e9bd056cf52e24e6ea6cf8b36b1d6f5874 /src/script | |
| parent | Merge #17095: util: Filter control characters out of log messages (diff) | |
| parent | Remove unused includes (diff) | |
| download | discoin-46d6930f8c7ba7cbcd7d86dd5d0117642fcbc819.tar.xz discoin-46d6930f8c7ba7cbcd7d86dd5d0117642fcbc819.zip | |
Merge #16659: refactoring: Remove unused includes
084e17cebd424b8e8ced674bc810eef4e6ee5d3b Remove unused includes (practicalswift)
Pull request description:
As requested by MarcoFalke in https://github.com/bitcoin/bitcoin/pull/16273#issuecomment-521332089:
This PR removes unused includes.
Please note that in contrast to #16273 I'm limiting the scope to the trivial cases of pure removals (i.e. no includes added) to make reviewing easier.
I'm seeking "Concept ACK":s for this obviously non-urgent minor cleanup.
Rationale:
* Avoids unnecessary re-compiles in case of header changes.
* Makes reasoning about code dependencies easier.
* Reduces compile-time memory usage.
* Reduces compilation time.
* Warm fuzzy feeling of being lean :-)
ACKs for top commit:
ryanofsky:
Code review ACK 084e17cebd424b8e8ced674bc810eef4e6ee5d3b. PR only removes include lines and it still compiles. In the worst case someone might have to explicitly add an include later for something now included implicitly. But maybe some effort was taken to avoid this, and it wouldn't be a tragedy anyway.
Tree-SHA512: 89de56edc6ceea4696e9579bccff10c80080821685b9fb4e8c5ef593b6e43cf662f358788701bb09f84867693f66b2e4db035b92b522a0a775f50b7ecffd6a6d
Diffstat (limited to 'src/script')
| -rw-r--r-- | src/script/interpreter.h | 1 | ||||
| -rw-r--r-- | src/script/keyorigin.h | 1 | ||||
| -rw-r--r-- | src/script/sign.h | 1 | ||||
| -rw-r--r-- | src/script/standard.h | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/src/script/interpreter.h b/src/script/interpreter.h index 276ff9a58..d63d8b85b 100644 --- a/src/script/interpreter.h +++ b/src/script/interpreter.h @@ -11,7 +11,6 @@ #include <vector> #include <stdint.h> -#include <string> class CPubKey; class CScript; diff --git a/src/script/keyorigin.h b/src/script/keyorigin.h index 610f23350..467605ce4 100644 --- a/src/script/keyorigin.h +++ b/src/script/keyorigin.h @@ -6,7 +6,6 @@ #define BITCOIN_SCRIPT_KEYORIGIN_H #include <serialize.h> -#include <streams.h> #include <vector> struct KeyOriginInfo diff --git a/src/script/sign.h b/src/script/sign.h index 0e751afd3..9d0a5b4d7 100644 --- a/src/script/sign.h +++ b/src/script/sign.h @@ -6,7 +6,6 @@ #ifndef BITCOIN_SCRIPT_SIGN_H #define BITCOIN_SCRIPT_SIGN_H -#include <boost/optional.hpp> #include <hash.h> #include <pubkey.h> #include <script/interpreter.h> diff --git a/src/script/standard.h b/src/script/standard.h index e45e2d92c..6db28dbc2 100644 --- a/src/script/standard.h +++ b/src/script/standard.h @@ -11,7 +11,6 @@ #include <boost/variant.hpp> -#include <stdint.h> static const bool DEFAULT_ACCEPT_DATACARRIER = true; |