diff options
| author | practicalswift <[email protected]> | 2017-08-01 12:22:41 +0200 |
|---|---|---|
| committer | practicalswift <[email protected]> | 2017-08-16 16:33:25 +0200 |
| commit | 64fb0ac016c7fd01c60c39af60f6431bac57f9ee (patch) | |
| tree | 8d8523dd68167f9a6299dd92cc9dd5e0fd162b23 /src/script | |
| parent | Merge #10901: Fix constness of ArgsManager methods (diff) | |
| download | discoin-64fb0ac016c7fd01c60c39af60f6431bac57f9ee.tar.xz discoin-64fb0ac016c7fd01c60c39af60f6431bac57f9ee.zip | |
Declare single-argument (non-converting) constructors "explicit"
In order to avoid unintended implicit conversions.
Diffstat (limited to 'src/script')
| -rw-r--r-- | src/script/interpreter.h | 2 | ||||
| -rw-r--r-- | src/script/sign.h | 4 | ||||
| -rw-r--r-- | src/script/standard.cpp | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/script/interpreter.h b/src/script/interpreter.h index 437826b5d..f845e1943 100644 --- a/src/script/interpreter.h +++ b/src/script/interpreter.h @@ -114,7 +114,7 @@ struct PrecomputedTransactionData { uint256 hashPrevouts, hashSequence, hashOutputs; - PrecomputedTransactionData(const CTransaction& tx); + explicit PrecomputedTransactionData(const CTransaction& tx); }; enum SigVersion diff --git a/src/script/sign.h b/src/script/sign.h index bd4586289..a0d8ee4ff 100644 --- a/src/script/sign.h +++ b/src/script/sign.h @@ -21,7 +21,7 @@ protected: const CKeyStore* keystore; public: - BaseSignatureCreator(const CKeyStore* keystoreIn) : keystore(keystoreIn) {} + explicit BaseSignatureCreator(const CKeyStore* keystoreIn) : keystore(keystoreIn) {} const CKeyStore& KeyStore() const { return *keystore; }; virtual ~BaseSignatureCreator() {} virtual const BaseSignatureChecker& Checker() const =0; @@ -54,7 +54,7 @@ public: /** A signature creator that just produces 72-byte empty signatures. */ class DummySignatureCreator : public BaseSignatureCreator { public: - DummySignatureCreator(const CKeyStore* keystoreIn) : BaseSignatureCreator(keystoreIn) {} + explicit DummySignatureCreator(const CKeyStore* keystoreIn) : BaseSignatureCreator(keystoreIn) {} const BaseSignatureChecker& Checker() const override; bool CreateSig(std::vector<unsigned char>& vchSig, const CKeyID& keyid, const CScript& scriptCode, SigVersion sigversion) const override; }; diff --git a/src/script/standard.cpp b/src/script/standard.cpp index 9570b8c8d..0f720d9e7 100644 --- a/src/script/standard.cpp +++ b/src/script/standard.cpp @@ -253,7 +253,7 @@ class CScriptVisitor : public boost::static_visitor<bool> private: CScript *script; public: - CScriptVisitor(CScript *scriptin) { script = scriptin; } + explicit CScriptVisitor(CScript *scriptin) { script = scriptin; } bool operator()(const CNoDestination &dest) const { script->clear(); |