diff options
| author | Cory Fields <[email protected]> | 2020-05-26 13:43:54 -0400 |
|---|---|---|
| committer | fanquake <[email protected]> | 2020-07-01 21:40:51 +0800 |
| commit | f1a0314c537791f202dfb7c1209f0e04ba7988c3 (patch) | |
| tree | 64e3cba6dc9d7650b8788c342c0fc57a942e5e2a /src/script/script_error.cpp | |
| parent | Merge #19331: build: Do not include server symbols in wallet (diff) | |
| download | discoin-f1a0314c537791f202dfb7c1209f0e04ba7988c3.tar.xz discoin-f1a0314c537791f202dfb7c1209f0e04ba7988c3.zip | |
gui: change combiner for signals to optional_last_value
optional_last_value, which does not throw, has replaced optional_value as
boost's default combiner. Besides being better supported, it also doesn't
trigger gcc's -Wmaybe-unitialized warning, presumably because exceptions no
longer bubble-up out of signals:
```bash
boost/signals2/last_value.hpp:54:36: warning: '*((void*)& value +1)' may be used uninitialized in this function [-Wmaybe-uninitialized]
if(value) return value.get();
```
The change in default happened in Boost 1.39.0 (along with the
introduction of the signals 2 library. More information is available here:
https://www.boost.org/doc/libs/1_73_0/doc/html/signals2/rationale.html#id-1.3.36.9.4
and here:
https://www.boost.org/doc/libs/1_73_0/doc/html/boost/signals2/optional_last_value.html
Co-authored-by: fanquake <[email protected]>
Diffstat (limited to 'src/script/script_error.cpp')
0 files changed, 0 insertions, 0 deletions