diff options
| author | Wladimir J. van der Laan <[email protected]> | 2020-05-06 14:19:26 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2020-05-06 14:19:41 +0200 |
| commit | 88b2652fadf6e004e751d48884ae8d4cf5c452b8 (patch) | |
| tree | 08e9371ef15834cff89596ff2451b2f90656097a /src/script/script_error.cpp | |
| parent | Merge #18843: build: warn on potentially uninitialized reads (diff) | |
| parent | wallet: Fix typo in assert that is compile-time true (diff) | |
| download | discoin-88b2652fadf6e004e751d48884ae8d4cf5c452b8.tar.xz discoin-88b2652fadf6e004e751d48884ae8d4cf5c452b8.zip | |
Merge #18853: wallet: Fix typo in assert that is compile-time true
fa47cf9d95dc2c2822fc96df16f179176935bf96 wallet: Fix typo in assert that is compile-time true (MarcoFalke)
Pull request description:
Commit 92bcd70808b9cac56b184903aa6d37baf9641b37 presumably added a check that a `dest` of type `CNoDestination` implies an empty `scriptChange`.
However, it accidentally checked for `boost::variant::empty`, which always returns false: https://www.boost.org/doc/libs/1_72_0/doc/html/boost/variant.html#id-1_3_46_5_4_1_1_16_2-bb
ACKs for top commit:
Sjors:
utACK fa47cf9d95dc2c2822fc96df16f179176935bf96
Tree-SHA512: 9626b1e2947039853703932a362c2ee204e002d3344856eb93eef0e0f833401336f2dfa80fd43b83c8ec6eac624e6302aee771fb67aec436ba6483be02b8d615
Diffstat (limited to 'src/script/script_error.cpp')
0 files changed, 0 insertions, 0 deletions