diff options
| author | fanquake <[email protected]> | 2020-08-28 19:21:02 +0800 |
|---|---|---|
| committer | fanquake <[email protected]> | 2020-08-28 19:44:47 +0800 |
| commit | 4326515f01d7938bb448e7a9338dcc9c98497847 (patch) | |
| tree | 2da64ff552c6428a8c91a668bc1123af259211d0 /src/script/script_error.cpp | |
| parent | Merge #19067: tests: Add fuzzing harness for CNode (diff) | |
| parent | chain: Remove UB CChain comparison (diff) | |
| download | discoin-4326515f01d7938bb448e7a9338dcc9c98497847.tar.xz discoin-4326515f01d7938bb448e7a9338dcc9c98497847.zip | |
Merge #19822: chain: Fix CChain comparison UB by removing it (it was unused)
df536883d263781c2abe944afc85f681cda635ed chain: Remove UB CChain comparison (Carl Dong)
Pull request description:
Comparing two empty `CChain`s is currently undefined behaviour, and resulted in false assertion failures when comparing identical empty `CChain`s in local testing.
Let's just remove this comparison operator since it doesn't seem to be used anywhere.
ACKs for top commit:
practicalswift:
ACK df536883d263781c2abe944afc85f681cda635ed -- patch is guaranteed to be correct :)
MarcoFalke:
cr ACK df536883d263781c2abe944afc85f681cda635ed
Tree-SHA512: db10bac364fc965b56abf7a5bac48018786b14806ffe107e3e8eb24d5004a29331f3387dfe3409a3452a6750d3329e3f354265d787ebb3abfccabe77b28a54d5
Diffstat (limited to 'src/script/script_error.cpp')
0 files changed, 0 insertions, 0 deletions