diff options
| author | MarcoFalke <[email protected]> | 2020-10-19 09:18:11 +0200 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2020-10-19 09:18:16 +0200 |
| commit | 152ddb31975875b8801043ea8342a7354357e282 (patch) | |
| tree | 5abfacf29a49a48ca7ebff71b73982e3cf91ef3a /src/script/script_error.cpp | |
| parent | Merge #20082: [bugfix] random: fixes read buffer to use min rather than max (diff) | |
| parent | test: Fix -Wunused-function warning if configured --without-libs (diff) | |
| download | discoin-152ddb31975875b8801043ea8342a7354357e282.tar.xz discoin-152ddb31975875b8801043ea8342a7354357e282.zip | |
Merge #20180: test: Fix -Wunused-function warnings if configured --without-libs
76bbcc414f3001b16ac0101f738ed0b3e6f1a372 test: Fix -Wunused-function warning if configured --without-libs (Hennadii Stepanov)
Pull request description:
On master (80c8a02f1b4f6ad2b5c02595d66a74db22373ed4) compiling with gcc:
```
$ ./configure --without-libs
$ make clean && make
...
test/script_tests.cpp:1369:23: warning: ‘CScriptWitness script_tests::ScriptWitnessFromJSON(const UniValue&)’ defined but not used [-Wunused-function]
1369 | static CScriptWitness ScriptWitnessFromJSON(const UniValue& univalue)
| ^~~~~~~~~~~~~~~~~~~~~
test/script_tests.cpp:1357:28: warning: ‘std::vector<CTxOut> script_tests::TxOutsFromJSON(const UniValue&)’ defined but not used [-Wunused-function]
1357 | static std::vector<CTxOut> TxOutsFromJSON(const UniValue& univalue)
| ^~~~~~~~~~~~~~
test/script_tests.cpp:1350:28: warning: ‘CMutableTransaction script_tests::TxFromHex(const string&)’ defined but not used [-Wunused-function]
1350 | static CMutableTransaction TxFromHex(const std::string& str)
| ^~~~~~~~~
...
```
This change is move-only (nice to review with `git diff --color-moved`).
ACKs for top commit:
practicalswift:
ACK 76bbcc414f3001b16ac0101f738ed0b3e6f1a372: diff looks correct
fanquake:
ACK 76bbcc414f3001b16ac0101f738ed0b3e6f1a372 - verified that this fixes the warnings. As mentioned can be reviewed with `git diff HEAD~ --color-moved=dimmed_zebra`.
Tree-SHA512: 7799ac190d1e3f15e38b36cfcd1f8d138be80cab6c6cfad8f7828e07deffc2037d52f1d967f7f233a3a8ed74eee184f5275076c2f364c3e363c77a1f40aa5030
Diffstat (limited to 'src/script/script_error.cpp')
0 files changed, 0 insertions, 0 deletions