diff options
| author | Wladimir J. van der Laan <[email protected]> | 2019-05-20 17:27:56 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2019-05-20 17:29:21 +0200 |
| commit | bb291b50f2542d8c775c4b20e58fb6c7d9c05999 (patch) | |
| tree | 33de698f083f35593f3e44230466d01aeecb33db /src/script/script.cpp | |
| parent | Merge #16051: depends: add patch to common dependencies (diff) | |
| parent | Disallow extended encoding for non-witness transactions (take 3) (diff) | |
| download | discoin-bb291b50f2542d8c775c4b20e58fb6c7d9c05999.tar.xz discoin-bb291b50f2542d8c775c4b20e58fb6c7d9c05999.zip | |
Merge #16021: p2p: Avoid logging transaction decode errors to stderr
fa2b52af32f6a4b9c22c270f36e92960c29ef364 Disallow extended encoding for non-witness transactions (take 3) (MarcoFalke)
Pull request description:
(previous title "p2p: Disallow extended encoding for non-witness transactions (take 3)")
Remote peers can send us illegally encoded txs and thus have us write to stderr. Fix that by not writing to stderr.
This is a follow up to the previous (incomplete) attempts at this:
* Disallow extended encoding for non-witness transactions #14039
* Add test for superfluous witness record in deserialization #15893
ACKs for commit fa2b52:
laanwj:
utACK fa2b52af32f6a4b9c22c270f36e92960c29ef364
ryanofsky:
utACK fa2b52af32f6a4b9c22c270f36e92960c29ef364. Would change title to something like "Avoid logging transaction decode errors to stderr" instead of "Disallow extended encoding for non-witness transactions." The current title is confusing because this PR isn't really allowing or disallowing anything, just logging the condition differently. "Disallow" also seems to contradict the "Allow exceptions from..." comments in the actual code.
Tree-SHA512: c66990e69b432d00dc1c5510bf976a1188664d0890a32d1e5c6459094e7e27da82a5d227627afcbc203676f5540eec74b7d9b1d71d2c62d3b2069e1781824b4d
Diffstat (limited to 'src/script/script.cpp')
0 files changed, 0 insertions, 0 deletions