diff options
| author | Russell Yanofsky <[email protected]> | 2017-08-14 19:44:02 -0400 |
|---|---|---|
| committer | Russell Yanofsky <[email protected]> | 2017-08-14 19:44:02 -0400 |
| commit | e067673f4ea7a74b7251282b48ea9ca57416533a (patch) | |
| tree | 9106b1044e0e734a76b417742f3c305a42ac9707 /src/rpc/rawtransaction.cpp | |
| parent | Get rid of redundant RPC params.size() checks (diff) | |
| download | discoin-e067673f4ea7a74b7251282b48ea9ca57416533a.tar.xz discoin-e067673f4ea7a74b7251282b48ea9ca57416533a.zip | |
Avoid treating null RPC arguments different from missing arguments
This changes RPC methods to treat null arguments the same as missing arguments,
instead of throwing type errors. Specifically:
- `getbalance` method now returns the wallet balance when the `account` param
is null instead of throwing a type error (same as when parameter is missing).
It is still an error to supply `minconf` or `watchonly` options when the
account is null.
- `addnode` and `setban` methods now return help text instead of type errors if
`command` params are null (same as when params are missing).
- `sendrawtransaction`, `setaccount`, `movecmd`, `sendfrom`,
`addmultisigaddress`, `listaccounts`, `lockunspent` methods accept null
default values where missing values were previously allowed, and treat them
the same.
Diffstat (limited to 'src/rpc/rawtransaction.cpp')
| -rw-r--r-- | src/rpc/rawtransaction.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp index 9d9fef664..10fc9c162 100644 --- a/src/rpc/rawtransaction.cpp +++ b/src/rpc/rawtransaction.cpp @@ -922,7 +922,7 @@ UniValue sendrawtransaction(const JSONRPCRequest& request) const uint256& hashTx = tx->GetHash(); CAmount nMaxRawTxFee = maxTxFee; - if (request.params.size() > 1 && request.params[1].get_bool()) + if (!request.params[1].isNull() && request.params[1].get_bool()) nMaxRawTxFee = 0; CCoinsViewCache &view = *pcoinsTip; |