diff options
| author | Dan Raviv <[email protected]> | 2017-08-26 16:36:46 +0300 |
|---|---|---|
| committer | Dan Raviv <[email protected]> | 2017-08-28 01:29:48 +0300 |
| commit | b426e24678eb65d791cb505011e3ba4655aef1cd (patch) | |
| tree | eb76718af998f0eb41aa20ce82fb51365222bb71 /src/policy | |
| parent | Merge #11151: Fix header guards using reserved identifiers (diff) | |
| download | discoin-b426e24678eb65d791cb505011e3ba4655aef1cd.tar.xz discoin-b426e24678eb65d791cb505011e3ba4655aef1cd.zip | |
Remove redundant explicitly defined copy ctors
CFeeRate and CTxMemPoolEntry have explicitly defined copy ctors which has the same functionality as the implicit default copy ctors which would have been generated otherwise.
Besides being redundant, it violates the rule of three (see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) ).
(Of course, the rule of three doesn't -really- cause a resource management issue here, but the reason for that is exactly that there is no need for an explicit copy ctor in the first place since no resources are being managed).
CFeeRate has an explicitly defined copy ctor which has the same functionality as the implicit default copy ctor which would h
ave been generated otherwise.
Diffstat (limited to 'src/policy')
| -rw-r--r-- | src/policy/feerate.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/policy/feerate.h b/src/policy/feerate.h index 565da6c15..7e519e3ef 100644 --- a/src/policy/feerate.h +++ b/src/policy/feerate.h @@ -26,7 +26,6 @@ public: explicit CFeeRate(const CAmount& _nSatoshisPerK): nSatoshisPerK(_nSatoshisPerK) { } /** Constructor for a fee rate in satoshis per kB. The size in bytes must not exceed (2^63 - 1)*/ CFeeRate(const CAmount& nFeePaid, size_t nBytes); - CFeeRate(const CFeeRate& other) { nSatoshisPerK = other.nSatoshisPerK; } /** * Return the fee in satoshis for the given size in bytes. */ |