diff options
| author | MeshCollider <[email protected]> | 2019-07-30 20:31:12 +1200 |
|---|---|---|
| committer | MeshCollider <[email protected]> | 2019-07-30 20:31:32 +1200 |
| commit | ff57fb45789253bb46511d57a916a67d3c0c1500 (patch) | |
| tree | 4b24f5d92caab8f4e429089e80fc75f1523b2024 /src/interfaces/node.cpp | |
| parent | Merge #16484: doc: update labels in CONTRIBUTING.md (diff) | |
| parent | Add setting as known type (diff) | |
| download | discoin-ff57fb45789253bb46511d57a916a67d3c0c1500.tar.xz discoin-ff57fb45789253bb46511d57a916a67d3c0c1500.zip | |
Merge #15709: wallet: Do not add "setting" key as unknown
914923d125f5d17b39b4dc05f666d130e80a68b2 Add setting as known type (Peter Bushnell)
Pull request description:
When loading old wallets I get "Unknown wallet records" showing up in the log file. The key that is adding to the unknown record count is "setting", this is a known key removed in the 0.6 release of Bitcoin in the commit linked below. The "setting" key is not known to the wallet anymore, like "acentry" which is not added as an unknown record, but the "setting" key was used in previous versions of Bitcoin.
https://github.com/bitcoin/bitcoin/commit/972060ce0e9746c979ce0ddeeb997121414c1d58#diff-8094838580e1bb7a3bb8fc78dcebc733
ACKs for top commit:
laanwj:
ACK 914923d125f5d17b39b4dc05f666d130e80a68b2, this code change is straightforward enough and I don't think it makes sense to warn about this key being present.
meshcollider:
ACK 914923d125f5d17b39b4dc05f666d130e80a68b2
Tree-SHA512: 6346690c05cebae2dcd868512322bf5250f6fbd07abb5e747065444185d3f69e19e1a99e3f38d6e34535ffd6979b2297100ba9c7da8e45ca792598eded5ae0d3
Diffstat (limited to 'src/interfaces/node.cpp')
0 files changed, 0 insertions, 0 deletions