diff options
| author | fanquake <[email protected]> | 2020-05-11 11:33:42 +0800 |
|---|---|---|
| committer | fanquake <[email protected]> | 2020-05-11 12:20:25 +0800 |
| commit | ec4d27fa8bdc60315c21e71ab989905bf915225d (patch) | |
| tree | e499861d10f9715d6104ff90d7d809329eeb4e55 /src/interfaces/node.cpp | |
| parent | Merge #18901: fuzz: use std::optional for sep_pos_opt variable (diff) | |
| parent | build: Enable -Werror=sign-compare (diff) | |
| download | discoin-ec4d27fa8bdc60315c21e71ab989905bf915225d.tar.xz discoin-ec4d27fa8bdc60315c21e71ab989905bf915225d.zip | |
Merge #18216: test, build: Enable -Werror=sign-compare
68537275bd91d1dc14a69609ae443f955bfdbd64 build: Enable -Werror=sign-compare (Ben Woosley)
eac6a3080d38cfd4eb7204ecd327df213958e51a refactor: Rework asmap Interpret to avoid ptrdiff_t (Ben Woosley)
df37377e30678ac9b8338ea920e50b7296da6bd5 test: Fix outstanding -Wsign-compare errors (Ben Woosley)
Pull request description:
Disallowing sign-comparison mismatches can help to prevent the introduction of overflow and interpretation bugs.
In this case, ~all~ most existing violations are in the tests, and most simply required annotating the literal as unsigned for comparison.
This was previously prevented by violations in leveldb which were fixed upstream and merged in #17398. You can test that by building this branch against: 22d11187ee3c7abfe9d43c9eb68f102498cc2b9a vs 75fb37ce68289eb7e00e2ccdd2ef7f9271332545
ACKs for top commit:
fjahr:
re-ACK 68537275bd91d1dc14a69609ae443f955bfdbd64
practicalswift:
ACK 68537275bd91d1dc14a69609ae443f955bfdbd64
Tree-SHA512: 14b5daa38c496fb51548feb30fb4dd179e6f76a8d355f52bc8e2a18f2f9340f0bc98dcf36d8b3d6521045d013891c3103749a4eda88ceef00202a6a0cf93f73c
Diffstat (limited to 'src/interfaces/node.cpp')
0 files changed, 0 insertions, 0 deletions