diff options
| author | MarcoFalke <[email protected]> | 2020-04-10 12:50:24 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2020-04-10 12:50:51 -0400 |
| commit | 6ab96ec5469ceea8544fb07e31118c295dbe57ca (patch) | |
| tree | 362e17219dded7fcdc5bd7ada6ffa4a4333b7f37 /src/interfaces/node.cpp | |
| parent | build: Bump version to 0.20.99 (diff) | |
| parent | test: update and harden interface_bitcoin_cli tests (diff) | |
| download | discoin-6ab96ec5469ceea8544fb07e31118c295dbe57ca.tar.xz discoin-6ab96ec5469ceea8544fb07e31118c295dbe57ca.zip | |
Merge #18574: cli: call getbalances.ismine.trusted instead of getwalletinfo.balance
5df0877f91f4ed59031b0d7dcd66780df87ac1af test: update and harden interface_bitcoin_cli tests (Jon Atack)
75019774c96795ef1a57af2a92dd9491f5065cc5 cli -getinfo: use getbalances instead of deprecated getwalletinfo balance (Jon Atack)
Pull request description:
Extracted from #18453 to preserve that PR as a discussion on multiwallet RPC/CLI.
This PR updates `bitcoin-cli -getinfo` to fetch the wallet balance from `getbalances` in order to no longer depend on `getwalletinfo.balance` which was deprecated a year ago in facfb41.
I found this when removing the getwalletinfo() `balance`, `unconfirmed_balance`, and `immature_balance` fields to see what broke from depending on them.
I didn't see any perceivable change in `-getinfo` run time from the change.
Test coverage for this change is provided by `test/functional/interface_bitcoin_cli.py`, which the second commit updates to (a) no longer depend on getwalletinfo.balances and (b) test the -getinfo blockcount and balance fields against non-default, non-zero values.
ACKs for top commit:
robot-visions:
ACK 5df0877
MarcoFalke:
ACK 5df0877
vasild:
re-ACK 5df0877f9
promag:
Code review ACK 5df0877f91f4ed59031b0d7dcd66780df87ac1af.
theStack:
ACK https://github.com/bitcoin/bitcoin/commit/5df0877f91f4ed59031b0d7dcd66780df87ac1af
Tree-SHA512: 0dd8c62f915b1c0112e42b132dcf74a141bdd1f51e7c17d4a698b374ec296f4f9836f7058dbe237cf24f9bfb32ea5000e14f7089e2e86472d9c6a175be26e910
Diffstat (limited to 'src/interfaces/node.cpp')
0 files changed, 0 insertions, 0 deletions