diff options
| author | Russell Yanofsky <[email protected]> | 2018-04-08 14:37:50 -0400 |
|---|---|---|
| committer | Russell Yanofsky <[email protected]> | 2019-02-22 15:43:02 -0400 |
| commit | 318f41fb2cae0a46b4e4be49156562b8ed640f0c (patch) | |
| tree | 0eba3861ed4428126b2e068d79e93895375c8163 /src/interfaces/node.cpp | |
| parent | Remove use of AcceptToMemoryPool in wallet code (diff) | |
| download | discoin-318f41fb2cae0a46b4e4be49156562b8ed640f0c.tar.xz discoin-318f41fb2cae0a46b4e4be49156562b8ed640f0c.zip | |
circular-dependencies: Avoid treating some .h/.cpp files as a unit
This avoids a bogus circular dependency error in the next commit:
interfaces/chain -> interfaces/wallet -> wallet/wallet -> interfaces/chain
Which is incorrect, because interfaces/chain.cpp depends only on the
interfaces/wallet.h file, not the interfaces/wallet.cpp file, and it is
wrong to treat these as a unit. Inside the interfaces directory, .h files
contain abstract class definitions and .cpp files contain implementations of
those classes, so you don't need to link against .cpp files if you're only
using the abstract class definition in the .h file.
An alternative fix might be to rename all the cpp files in the interfaces
directory like: chain.cpp->chain_impl.cpp, node.cpp->node_impl.cpp. But just
getting the linter to treat these files as independent dependencies seemed
like it would allow keeping code organization straightforward and avoiding
the need to rename things.
Diffstat (limited to 'src/interfaces/node.cpp')
0 files changed, 0 insertions, 0 deletions