diff options
| author | fanquake <[email protected]> | 2019-09-11 15:21:12 +1000 |
|---|---|---|
| committer | fanquake <[email protected]> | 2019-09-11 15:37:13 +1000 |
| commit | 2296fe65f598eefb72e944cefcca462e740bfaf3 (patch) | |
| tree | f03b95e7becc735e06e2aa25990075c9826b9929 /src/interfaces/node.cpp | |
| parent | Merge #16413: depends: Bump QT to LTS release 5.9.8 (diff) | |
| parent | signrawtransaction*: improve error for partial signing (diff) | |
| download | discoin-2296fe65f598eefb72e944cefcca462e740bfaf3.tar.xz discoin-2296fe65f598eefb72e944cefcca462e740bfaf3.zip | |
Merge #16251: Improve signrawtransaction error reporting
ec4c79326bb670c2cc1757ecfb1900f8460c5257 signrawtransaction*: improve error for partial signing (Anthony Towns)
3c481f8921bbc587cf287329f39243abe703b868 signrawtransactionwithkey: better error messages for bad redeemScript/witnessScript (Anthony Towns)
Pull request description:
Two fixes for `signrawtransactionwith{key,wallet}` (in addition to #16250): one that checks redeemScript/witnessScript matches scriptPubKey (and if both are provided that they match each other sanely), and the other changes the warning when some-but-not-all the signatures for a CHECKMULTISIG are provided to something that suggests more signatures may be all that's required.
Fixes: #13218
Fixes: #14823
ACKs for top commit:
instagibbs:
utACK https://github.com/bitcoin/bitcoin/pull/16251/commits/ec4c79326bb670c2cc1757ecfb1900f8460c5257
achow101:
Code Review ACK ec4c79326bb670c2cc1757ecfb1900f8460c5257
meshcollider:
utACK ec4c79326bb670c2cc1757ecfb1900f8460c5257
Tree-SHA512: 0c95c91d498e85b834662b9e5c83f336ed5fd306be7701ce1dbfa0836fbeb448a267a796585512f7496e820be668b07c2a0a2f45e52dc23f09ee7d9c87e42b35
Diffstat (limited to 'src/interfaces/node.cpp')
0 files changed, 0 insertions, 0 deletions