diff options
| author | MarcoFalke <[email protected]> | 2019-10-28 15:09:56 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-10-28 15:10:06 -0400 |
| commit | 4c1090c882ea15ba4d10a2f7f320f3c0eb490ebd (patch) | |
| tree | 60332191fe0bd4c847c60dc6a4751f77e3be6e2a /src/init.cpp | |
| parent | Merge #17266: util: Rename DecodeDumpTime to ParseISO8601DateTime (diff) | |
| parent | refactor: Remove redundant c_str() calls in formatting (diff) | |
| download | discoin-4c1090c882ea15ba4d10a2f7f320f3c0eb490ebd.tar.xz discoin-4c1090c882ea15ba4d10a2f7f320f3c0eb490ebd.zip | |
Merge #17279: refactor: Remove redundant c_str() calls in formatting
c72906dcc11a73fa06a0adf97557fa756b551bee refactor: Remove redundant c_str() calls in formatting (Wladimir J. van der Laan)
Pull request description:
Our formatter, tinyformat, *never* needs `c_str()` for strings. Still, many places call it redundantly, resulting in longer code and a slight overhead.
Remove redundant `c_str()` calls for:
- `strprintf`
- `LogPrintf`
- `tfm::format`
(also, combined with #17095, I think this improves logging in case of unexpected embedded NULL characters)
ACKs for top commit:
ryanofsky:
Code review ACK c72906dcc11a73fa06a0adf97557fa756b551bee. Easy to review with `git log -p -n1 --word-diff-regex=. -U0 c72906dcc11a73fa06a0adf97557fa756b551bee`
Tree-SHA512: 9e21e7bed8aaff59b8b8aa11571396ddc265fb29608c2545b1fcdbbb36d65b37eb361db6688dd36035eab0c110f8de255375cfda50df3d9d7708bc092f67fefc
Diffstat (limited to 'src/init.cpp')
| -rw-r--r-- | src/init.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/init.cpp b/src/init.cpp index da4d32266..93221efe9 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -943,7 +943,7 @@ bool AppInitParameterInteraction() } if (!fs::is_directory(GetBlocksDir())) { - return InitError(strprintf(_("Specified blocks directory \"%s\" does not exist.").translated, gArgs.GetArg("-blocksdir", "").c_str())); + return InitError(strprintf(_("Specified blocks directory \"%s\" does not exist.").translated, gArgs.GetArg("-blocksdir", ""))); } // parse and validate enabled filter types |