diff options
| author | MarcoFalke <[email protected]> | 2020-10-08 11:38:36 +0200 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2020-10-08 11:38:47 +0200 |
| commit | 9dd4de2832e298398436b957375d62de67f0a928 (patch) | |
| tree | 731dd3a10ba0cd8b3a134e49085c671699e5a088 /src/httpserver.h | |
| parent | Merge #20092: util: Do not use gArgs global in ArgsManager member functions (diff) | |
| parent | Avoid 'timing mishap' warnings when mocking (diff) | |
| download | discoin-9dd4de2832e298398436b957375d62de67f0a928.tar.xz discoin-9dd4de2832e298398436b957375d62de67f0a928.zip | |
Merge #20027: Use mockable time everywhere in net_processing
b6834e312a6a7bb395ec7266bc9469384639df96 Avoid 'timing mishap' warnings when mocking (Pieter Wuille)
ec3916f40a3fc644ecbbaaddef6258937c7fcfbc Use mockable time everywhere in net_processing (Pieter Wuille)
Pull request description:
The fact that net_processing uses a mix of mockable tand non-mockable time functions made it hard to write functional tests for #19988.
I'm opening this as a separate PR as I believe it's independently useful. In some ways this doesn't go quite as far as it could, as there are now several data structures that could be converted to `std::chrono` types as well now. I haven't done that here, but I'm happy to reconsider that.
ACKs for top commit:
MarcoFalke:
ACK b6834e312a 🌶
jnewbery:
utACK b6834e312a6a7bb395ec7266bc9469384639df96
naumenkogs:
utACK b6834e3
Tree-SHA512: 6528a167c57926ca12894e0c476826411baf5de2f7b01c2125b97e5f710e620f427bbb13f72bdfc3de59072e56a9c1447bce832f41c725e00e81fea019518f0e
Diffstat (limited to 'src/httpserver.h')
0 files changed, 0 insertions, 0 deletions