diff options
| author | MarcoFalke <[email protected]> | 2019-10-10 12:09:25 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-10-10 12:12:54 -0400 |
| commit | 59f0687fea26a19bfb90a3f55c67ed4aa895bbbd (patch) | |
| tree | 4e9fbafa74359c84e8f48fad4fb9a7b29b0ef346 /src/httpserver.h | |
| parent | Merge #16689: rpc: add missing fields to wallet rpc help output (diff) | |
| parent | test: add unit test for wallet watch-only methods involving PubKeys (diff) | |
| download | discoin-59f0687fea26a19bfb90a3f55c67ed4aa895bbbd.tar.xz discoin-59f0687fea26a19bfb90a3f55c67ed4aa895bbbd.zip | |
Merge #16786: test: add unit test for wallet watch-only methods involving PubKeys
a57a1d42d52fe51e5b413a1fd3a5ef2b7a2120e3 test: add unit test for wallet watch-only methods involving PubKeys (Sebastian Falbesoner)
Pull request description:
The motivation for this addition was to unit test the function `wallet.cpp:ExtractPubKey()` (see recent change in commit 798a589aff64b83a0844688a661f4bd987c3340c) which is however static and only indirectly available via the public methods `AddWatchOnly()`, `LoadWatchOnly()` and `RemoveWatchOnly()`. Since the first of those methods also stores the addresses to the disk, the second, simpler one was chosen which only operates in memory.
ACKs for top commit:
Sjors:
ACK a57a1d4
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/16786/commits/a57a1d42d52fe51e5b413a1fd3a5ef2b7a2120e3
Sjors:
re-ACK a57a1d4
Tree-SHA512: 92a242204ab533022cd848662997372c41815b1265d07b3d96305697f801db29a5ba5668337faf4bea702bec1451972529afd6665927fb142aaf91700a338b26
Diffstat (limited to 'src/httpserver.h')
0 files changed, 0 insertions, 0 deletions