diff options
| author | fanquake <[email protected]> | 2019-09-07 09:32:01 +0800 |
|---|---|---|
| committer | fanquake <[email protected]> | 2019-09-07 10:15:43 +0800 |
| commit | 0d20c42a014ff95aab1447a92605c3a194cfeecc (patch) | |
| tree | 61da84e6bcb1ec6863c5cacc925ced66870d7706 /src/httpserver.h | |
| parent | Merge #16798: Refactor rawtransaction_util's SignTransaction to separate prev... (diff) | |
| parent | Conservatively accept RBF bumps bumping one tx at the package limits (diff) | |
| download | discoin-0d20c42a014ff95aab1447a92605c3a194cfeecc.tar.xz discoin-0d20c42a014ff95aab1447a92605c3a194cfeecc.zip | |
Merge #16421: Conservatively accept RBF bumps bumping one tx at the package limits
5ce822efbe45513ce3517c1ca731ac6d6a0c3b54 Conservatively accept RBF bumps bumping one tx at the package limits (Matt Corallo)
Pull request description:
Based on #15681, this adds support for some simple cases of RBF inside of large packages. Issue pointed out by sdaftuar in #15681, and this fix (or a broader one) is required ot make #15681 fully useful.
Accept RBF bumps of single transactions (ie which evict exactly one
transaction) even when that transaction is a member of a package
which is currently at the package limit iff the new transaction
does not add any additional mempool dependencies from the original.
This could be made a bit looser in the future and still be safe,
but for now this fixes the case that a transaction which was
accepted by the carve-out rule will not be directly RBF'able
ACKs for top commit:
instagibbs:
re-ACK https://github.com/bitcoin/bitcoin/pull/16421/commits/5ce822efbe45513ce3517c1ca731ac6d6a0c3b54
ajtowns:
ACK 5ce822efbe45513ce3517c1ca731ac6d6a0c3b54 ; GetSizeWithDescendants is only change and makes sense
sipa:
Code review ACK 5ce822efbe45513ce3517c1ca731ac6d6a0c3b54. I haven't thought hard about the effect on potential DoS issues this policy change may have.
Tree-SHA512: 1cee3bc57393940a30206679eb60c3ec8cb4f4825d27d40d1f062c86bd22542dd5944fa5567601c74c8d9fd425333ed3e686195170925cfc68777e861844bd55
Diffstat (limited to 'src/httpserver.h')
0 files changed, 0 insertions, 0 deletions