diff options
| author | Wladimir J. van der Laan <[email protected]> | 2018-02-06 12:34:17 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2018-02-06 12:48:59 +0100 |
| commit | 9a32114626fca1f4d14cb53fcd54b65d2e48ff5b (patch) | |
| tree | 7549e36a33217245aae54e03e3fb161ca9327c55 /src/httpserver.cpp | |
| parent | Merge #12342: Extend #11583 to include "version handshake timeout" message (diff) | |
| parent | net: Move misbehaving logging to net logging category (diff) | |
| download | discoin-9a32114626fca1f4d14cb53fcd54b65d2e48ff5b.tar.xz discoin-9a32114626fca1f4d14cb53fcd54b65d2e48ff5b.zip | |
Merge #12218: net: Move misbehaving logging to net logging category
d3a185a net: Move misbehaving logging to net logging category (Wladimir J. van der Laan)
Pull request description:
This moves the error messages for misbehavior (when available) into the line that reports the misbehavior, as well as moves the logging to the `net` category.
This is a continuation of #11583 and avoids serious-looking errors due to misbehaving peers. As it is impossible to correlate the `peer=X` numbers to specific incoming connections now without enabling the `net` category, it doesn't really help to see these messages by default.
To do this, Misbehaving() gains an optional `message` argument.
E.g. change:
2018-01-18 16:02:27 Misbehaving: x.x.x.x:62174 peer=164603 (80 -> 100) BAN THRESHOLD EXCEEDED
2018-01-18 16:02:27 ERROR: non-continuous headers sequence
to
2018-01-18 16:02:27 Misbehaving: x.x.x.x:62174 peer=164603 (80 -> 100) BAN THRESHOLD EXCEEDED: non-continuous headers sequence
When there is a category for "important" net messages (see #12219 ), we should move it there.
Tree-SHA512: 51c97e9a649bf5409f2fd4625fa1243a036e9c9de6037bb064244207408c2e0eb025e3af80866df673cdc006b8f35dc4078d074033f0d4c6a73bbb03949a269f
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions