diff options
| author | Wladimir J. van der Laan <[email protected]> | 2019-07-08 13:19:39 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2019-07-08 13:33:07 +0200 |
| commit | 983c84844c59acf4dea510fb5554de8743417fb7 (patch) | |
| tree | addaeeca8370f52e93214644c6e5507af6fd9b91 /src/httpserver.cpp | |
| parent | Merge #16332: rpc: Add logpath description for getrpcinfo (diff) | |
| parent | build: prune dbus from depends (diff) | |
| download | discoin-983c84844c59acf4dea510fb5554de8743417fb7.tar.xz discoin-983c84844c59acf4dea510fb5554de8743417fb7.zip | |
Merge #16352: build: prune dbus from depends
e8fabd9253400a7c3fe45b34bc572eb00ff5522d build: prune dbus from depends (fanquake)
Pull request description:
Since #8210 (59d063d07660d6e8d53ed8aa1eb8b0747ea6767c), we've been passing `-dbus-runtime` when configuring Qt.
```
qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus
-no-dbus ............. Do not build the Qt D-Bus module
-dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto]
-dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no]
```
This means we don't actually seem to be using the `D-Bus` we build in depends. This was pointed out by theuni at the time, [here](https://github.com/bitcoin/bitcoin/pull/7993#issuecomment-223114395) and [here](https://github.com/bitcoin/bitcoin/pull/8210#issuecomment-226930545), but was never followed up. dongcarl also bought it up as part of #16150.
I've tested building and running `bitcoin-qt` using depends on Debian. Needs further testing.
ACKs for top commit:
laanwj:
code review ACK e8fabd9253400a7c3fe45b34bc572eb00ff5522d
Tree-SHA512: 164e6e52b6f97c04aef42bd185e2a157bc1a42103840f9404c5a795749f45a8c2c35f35873395a3a56398b3cd5955496b90d9c885d929b434c9bc871695abe20
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions