diff options
| author | Wladimir J. van der Laan <[email protected]> | 2019-06-28 13:41:10 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2019-06-28 13:41:28 +0200 |
| commit | 935cd6b1ec08676969cf601159317b53f631393a (patch) | |
| tree | 5b87c2fec6355673d31c0e3ade3ce6a2ed1b202e /src/httpserver.cpp | |
| parent | Merge #16278: tests: Remove unused includes (diff) | |
| parent | util: Explain why the path is cached (diff) | |
| download | discoin-935cd6b1ec08676969cf601159317b53f631393a.tar.xz discoin-935cd6b1ec08676969cf601159317b53f631393a.zip | |
Merge #16300: util: Explain why the path is cached
fa69c3e6ca71800376761e264320c363f072dc2f util: Explain why the path is cached (MarcoFalke)
Pull request description:
The rationale for caching the datadir is given as
```
// This can be called during exceptions by LogPrintf(), so we cache the
// value so we don't have to do memory allocations after that.
```
Since 8c2d695c4a45bdd9378c7970b0fcba6e1efc01f9, the debug log location is actually cached itself in `m_file_path`.
So explain that the caching is now only used to guard against disk access on each call. (See also #16255)
ACKs for top commit:
promag:
ACK fa69c3e6ca71800376761e264320c363f072dc2f.
laanwj:
ACK fa69c3e6ca71800376761e264320c363f072dc2f
ryanofsky:
utACK fa69c3e6ca71800376761e264320c363f072dc2f. Good cleanup. Previous comment was confusing, and definitely not helpful if outdated.
Tree-SHA512: 02108c90026d6d7c02843aaf59a06b4e1fa63d5d4378bb7760f50767efc340dc94c259bf7afb32fa4d47952b48a4e91798d1e0ddc1b051d770405e078636793a
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions