diff options
| author | Wladimir J. van der Laan <[email protected]> | 2019-12-17 16:15:18 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2019-12-17 16:19:29 +0100 |
| commit | 7df6a7ea98121997af2dcc57a69046ae252a9ec6 (patch) | |
| tree | c6a64cc404a115e3be6aa073d32afbdcdbd117b9 /src/httpserver.cpp | |
| parent | Merge #17229: tests: Add fuzzing harnesses for various Base{32,58,64} and hex... (diff) | |
| parent | test: add IsRFC2544 tests (diff) | |
| download | discoin-7df6a7ea98121997af2dcc57a69046ae252a9ec6.tar.xz discoin-7df6a7ea98121997af2dcc57a69046ae252a9ec6.zip | |
Merge #17758: Fix CNetAddr::IsRFC2544 comment + tests
529d332fbfe633d60845a97e1a06f552bd63d0d4 test: add IsRFC2544 tests (Mark Tyneway)
419ef3b7cc04e3ab26252d7024da847dfd5ab1a3 CNetAddr: fix IsRFC2544 comment (Mark Tyneway)
Pull request description:
The comment describing the functionality of `CNetAddr::IsRFC2544` is incorrect.
https://github.com/bitcoin/bitcoin/blob/46d6930f8c7ba7cbcd7d86dd5d0117642fcbc819/src/netaddress.h#L57
It should actually read `198.18.0.0/15` based on [RFC 3330](https://tools.ietf.org/html/rfc3330):
```
198.18.0.0/15 - This block has been allocated for use in benchmark
tests of network interconnect devices. Its use is documented in
[RFC2544].
```
See [RFC 2544](https://tools.ietf.org/html/rfc2544) here.
See the implementation here:
https://github.com/bitcoin/bitcoin/blob/47d981e8273804a040d71665a4cb16038d6717e1/src/netaddress.cpp#L142-L145
This PR also adds tests for the minimum and maximum values that are valid RFC 2544 addresses.
ACKs for top commit:
practicalswift:
ACK 529d332fbfe633d60845a97e1a06f552bd63d0d4
laanwj:
ACK 529d332fbfe633d60845a97e1a06f552bd63d0d4
promag:
ACK 529d332fbfe633d60845a97e1a06f552bd63d0d4, nit could squash.
jonatack:
ACK 529d332fbfe633d60845a97e1a06f552bd63d0d4
Tree-SHA512: 954a9582856d77564e0ea5fd2e3d287d0cfc4ecfe0588115692d01005e8ca7ad8ab20ff390ded867dc91af2bfb758d4e73a336e6c0b7798846c30a6d69b8ae3d
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions