diff options
| author | fanquake <[email protected]> | 2020-05-13 20:59:18 +0800 |
|---|---|---|
| committer | fanquake <[email protected]> | 2020-05-13 21:17:07 +0800 |
| commit | 6c647c89db286edb26c140a46e73306e31f1ba91 (patch) | |
| tree | 4a0a78c7efde114cf93cc371f80cd94be8b64639 /src/httpserver.cpp | |
| parent | Merge #18814: rpc: Relock wallet only if most recent callback (diff) | |
| parent | build: Suppress -Wdeprecated-copy warnings (diff) | |
| download | discoin-6c647c89db286edb26c140a46e73306e31f1ba91.tar.xz discoin-6c647c89db286edb26c140a46e73306e31f1ba91.zip | |
Merge #18738: build: Suppress -Wdeprecated-copy warnings
0c63f808542ba02fc41aa90b1d96e9123f16d8ad build: Suppress -Wdeprecated-copy warnings (Hennadii Stepanov)
Pull request description:
Tomorrow, on Apr 23 the Ubuntu 20.04 release is expected. It packaged with Qt 5.12 LTS that has a nasty peculiarity to cause modern compilers, including Clang 10.0 and GCC 9.3, to emit spammy `-Wdeprecated-copy` warnings (#15822, #18419).
This PR suppress such warnings _temporarily_, until the [upstream is fixed](https://codereview.qt-project.org/c/qt/qtbase/+/272258).
Here are some affected systems (with system packages):
- Ubuntu 20.04 LTS + Qt 5.12.8 LTS + { Clang 10.0 | GCC 9.3 }
- Fedora 32 + Qt 5.13.2 + Clang 10.0
Reference: [QTBUG-75210](https://bugreports.qt.io/browse/QTBUG-75210)
Also see **fanquake**'s [comment](https://github.com/bitcoin/bitcoin/pull/18738#issuecomment-622956100).
ACKs for top commit:
MarcoFalke:
ACK 0c63f808542ba02fc41aa90b1d96e9123f16d8ad seems fine to disable this warning for the 0.21.0 release temporarily and then enable it for 0.22.0, when boost is removed.
fanquake:
ACK 0c63f808542ba02fc41aa90b1d96e9123f16d8ad - I think it's ok to suppress these for now, given that `-Wdeprecated-copy` is enabled (via `-Wextra`) in GCC 9 and Clang 10. The Qt output is pretty noisy, and there's a few warnings from Boost as well.
Tree-SHA512: 7064a3272bc9eae00b73a16c421ac58be148f374cbef87320e8f092f52761f6e98166eff60346b70867f8a69a9698a79455dc16b42d92f8fbe7c56519571ac08
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions