diff options
| author | Wladimir J. van der Laan <[email protected]> | 2019-10-30 10:42:44 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2019-10-30 10:42:57 +0100 |
| commit | 5728f88d645c124b980ecb6b6943a94a1ad46612 (patch) | |
| tree | 74b5512834dbc131c985a74cf171c1ea47b57445 /src/httpserver.cpp | |
| parent | Merge #17299: test: add reason checks for non-standard txs in test_IsStandard (diff) | |
| parent | Fix occurences of c_str() used with size() to data() (diff) | |
| download | discoin-5728f88d645c124b980ecb6b6943a94a1ad46612.tar.xz discoin-5728f88d645c124b980ecb6b6943a94a1ad46612.zip | |
Merge #17280: refactor: Change occurences of c_str() used with size() to data()
f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf Fix occurences of c_str() used with size() to data() (Wladimir J. van der Laan)
Pull request description:
Using `data()` better communicates the intent here.
~~Also, depending on how `c_str()` is implemented, this fixes undefined behavior: The part of the string after the first NULL character might have undefined contents (or even be inaccessible, worst case).~~ Apparently [this is no longer an issue with C++11](https://github.com/bitcoin/bitcoin/pull/17281#discussion_r339742128).
ACKs for top commit:
fjahr:
Code review ACK f3b51eb
practicalswift:
ACK f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf -- diff looks correct, `data()` more idiomatic
ryanofsky:
Code review ACK f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf. Most of these calls (including one in crypter.cpp) are passing text strings, not binary strings likely to contain `\0` and were probably safe before, but much better to avoid the possibility of bugs like this.
Tree-SHA512: 842e1bdd37efc4ece2ecb87ca34962aafef0a192180051def630607e349dc9c8b4e562481fff3de474515f493b4ee3ea53b00269a801a66e625326a38dfce5b8
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions