diff options
| author | Wladimir J. van der Laan <[email protected]> | 2020-05-14 20:43:31 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2020-05-14 20:43:45 +0200 |
| commit | 553bb3fc3d953e00770c11e25d20ecd0efe041e6 (patch) | |
| tree | 887902c9191c4aa31bd8d546d323f9222157f33e /src/httpserver.cpp | |
| parent | Merge #18796: scripts: security-check.py refactors (diff) | |
| parent | [net processing] Only send a getheaders for one block in an INV (diff) | |
| download | discoin-553bb3fc3d953e00770c11e25d20ecd0efe041e6.tar.xz discoin-553bb3fc3d953e00770c11e25d20ecd0efe041e6.zip | |
Merge #18962: net processing: Only send a getheaders for one block in an INV
746736639e6d05acdb85c866d4c605c947d4c500 [net processing] Only send a getheaders for one block in an INV (John Newbery)
Pull request description:
Headers-first is the primary method of announcement on the network. If a node fell back sending blocks by inv, it's probably for a re-org. The final block hash provided should be the highest, so send a getheaders and then fetch the blocks we need to catch up.
Sending many GETHEADERS messages to the peer would cause them to send a large number of potentially large HEADERS messages with redundant data, which is a waste of bandwidth.
ACKs for top commit:
sipa:
utACK 746736639e6d05acdb85c866d4c605c947d4c500
mzumsande:
utACK 746736639e6d05acdb85c866d4c605c947d4c500 as per ajtowns' reasoning.
naumenkogs:
utACK 7467366
ajtowns:
ACK 746736639e6d05acdb85c866d4c605c947d4c500
jonatack:
ACK 746736639e6d05acdb85c866d4c605c947d4c500
Tree-SHA512: 59e243b80d3f0873709dfacb2e4ffba34689aad7de31ec7f69a64e0e3a0756235a0150e4082ff5de823949ba4411ee1aed2344b4749b62e0eb1ea906e41f5ea9
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions