diff options
| author | MarcoFalke <[email protected]> | 2020-05-18 20:00:24 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2020-05-18 20:01:13 -0400 |
| commit | 362f9c60a54e673bb3daa8996f86d4bc7547eb13 (patch) | |
| tree | 25ec2bf313e61357675517d9849bfe114da8891f /src/httpserver.cpp | |
| parent | Merge #18938: tests: Fill fuzzing coverage gaps for functions in consensus/va... (diff) | |
| parent | docs: Add notes on how to diasble rpc timeout in functional tests while attat... (diff) | |
| download | discoin-362f9c60a54e673bb3daa8996f86d4bc7547eb13.tar.xz discoin-362f9c60a54e673bb3daa8996f86d4bc7547eb13.zip | |
Merge #18986: tests: Add capability to disable RPC timeout in functional tests
38c3dd9c706e7e84b2a4dbaf1424a3f1c3b694fc docs: Add notes on how to diasble rpc timeout in functional tests while attatching gdb. (codeShark149)
784ae096259955ea7a294114f5c021c9489d2717 test: Add capability to disable RPC timeout in functional tests. (codeShark149)
Pull request description:
Many times, especially while debugging RPC callbacks to core using gdb, the test timeout kicks in before the response can get back. This can be annoying and requires restarting the functional test as well as gdb attachment.
This PR adds a `--notimeout` flag into `test_framework` and sets the `rpc_timeout` accordingly if the flag is set.
The same effect can be achieved with newly added `--factor` flag but keeping a separate flag that explicitly disables the timeout can be easier for new testers to find it out and separates its purpose from the `--factor` flag.
Requesting review ryanofsky jnewbery as per the IRC discussion.
Update: After initial round of review, the approach is modified to accommodate the functionality in already existing `--factor` flag. `--factor` is changed to `--timeout-factor` to express its intent better.
ACKs for top commit:
MarcoFalke:
ACK 38c3dd9c706e7e84b2a4dbaf1424a3f1c3b694fc and thanks for fixing up all my typos :sweat_smile:
jnewbery:
ACK 38c3dd9c706e7e84b2a4dbaf1424a3f1c3b694fc.
Tree-SHA512: 9458dd1010288c62f8bb83f7a4893284fbbf938882dd65fc9e08810a910db07ef676e3100266028e5d4c8ce407b2267b3860595015da070c84a9d4a9816797db
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions