diff options
| author | Sebastian Falbesoner <[email protected]> | 2019-10-11 14:47:38 +0200 |
|---|---|---|
| committer | Sebastian Falbesoner <[email protected]> | 2019-10-14 15:03:11 +0200 |
| commit | 32d665c2657793c8b2cc7248d26d80a940acfe20 (patch) | |
| tree | 82af55789519306ce39db9595b5e3fb1a3debdf9 /src/httpserver.cpp | |
| parent | Merge #16983: doc: Add detailed info about Bitcoin Core files (diff) | |
| download | discoin-32d665c2657793c8b2cc7248d26d80a940acfe20.tar.xz discoin-32d665c2657793c8b2cc7248d26d80a940acfe20.zip | |
test: fix "tx-size-small" errors after default address change
Addresses #17043, affects RBF and BIP68 functional tests.
The "tx-size-small" policy rule rejects transactions with a non-witness size of
smaller than 82 bytes (see src/validation.cpp:MemPoolAccept::PreChecks(...)),
which corresponds to a transaction with 1 segwit input and 1 P2WPKH output.
Through the default address change, the created test transactions have segwit
inputs now and sending to short scriptPubKeys might violate this rule. By
bumping the dummy scriptPubKey size to 22 bytes (= the size of a P2WPKH
scriptPubKey), on all occurences the problem is solved.
The dummy scriptPubKey has the format:
21 <21-byte-long string of 'a' or 1s>
former commit messages, now squashed:
test: rbf, bip68: use constant DUMMY_P2WPKH_SCRIPT for bumped scriptPubKey
test: rbf, bip68: use constant DUMMY_P2WPKH_SCRIPT for dummy scriptPubKeys (b'a' * 35)
test: rbf, bip68: comment DUMMY_P2WPKH_SCRIPT constant, put into common (new) module
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions