diff options
| author | Jonas Schnelli <[email protected]> | 2019-04-08 09:06:31 +0200 |
|---|---|---|
| committer | Jonas Schnelli <[email protected]> | 2019-04-08 09:06:42 +0200 |
| commit | 327d2746fb9240ff0751a7c8f501c9745ba55bba (patch) | |
| tree | 1fe012932e42cf3b721d9551d7b3ad0e463b8fc3 /src/httpserver.cpp | |
| parent | Merge #15660: [qa] Overhaul p2p_compactblocks.py (diff) | |
| parent | Add regtests for HTTP status codes. (diff) | |
| download | discoin-327d2746fb9240ff0751a7c8f501c9745ba55bba.tar.xz discoin-327d2746fb9240ff0751a7c8f501c9745ba55bba.zip | |
Merge #15495: Add regtests for HTTP status codes
8f5d9431a Add regtests for HTTP status codes. (Daniel Kraft)
Pull request description:
This adds explicit tests for the returned HTTP status codes to `interface_rpc.py` (for error cases) and the HTTP JSON-RPC client in general for success.
#15381 brought up discussion about the HTTP status codes in general, and the general opinion was that the current choice may not be ideal but should not be changed to preserve compatibility with existing JSON-RPC clients. Thus it makes sense to actually test the current status to ensure this desired compatibility is not broken accidentally.
ACKs for commit 8f5d94:
laanwj:
utACK 8f5d9431a36740aa12abc0acea64df48fe32d2a6
promag:
utACK 8f5d943.
jonasschnelli:
utACK 8f5d9431a36740aa12abc0acea64df48fe32d2a6
Tree-SHA512: 82503ccd134dd9145304e95cb6c61755f100bee27593d567cdd5c0c554d47e7b06d937456cab04107f46f4984930355db65d5e711008a0b05f2b8feec9f2950e
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions