diff options
| author | fanquake <[email protected]> | 2020-02-06 14:31:23 +0800 |
|---|---|---|
| committer | fanquake <[email protected]> | 2020-02-06 14:43:38 +0800 |
| commit | 23fab1a3dfe6f308880197dbe2bd7ce70866f13c (patch) | |
| tree | d9b099dcadc73db023951f53dfba36d5e960884c /src/httpserver.cpp | |
| parent | Merge #18003: build: remove --large-address-aware linker flag (diff) | |
| parent | gui: Fix unintialized WalletView::progressDialog (diff) | |
| download | discoin-23fab1a3dfe6f308880197dbe2bd7ce70866f13c.tar.xz discoin-23fab1a3dfe6f308880197dbe2bd7ce70866f13c.zip | |
Merge #18062: gui: Fix unintialized WalletView::progressDialog
acf8abc7f3cf7efa418a46f9f69f23f1a5035582 gui: Fix unintialized WalletView::progressDialog (João Barbosa)
Pull request description:
#17911 shows that it's possible to read the unintialized `progressDialog` in https://github.com/bitcoin/bitcoin/blob/f32564f0a73c5ad1a107dd112e40516f39d1a51e/src/qt/walletview.cpp#L296-L297.
And the debugger shows
```
(gdb) bt
#0 0x0000555556687c60 in QProgressDialog::wasCanceled() const ()
#1 0x000055555572989f in WalletView::showProgress (this=0x5555577d7a70,
title=..., nProgress=1) at qt/walletview.cpp:322
```
Closes #17911.
ACKs for top commit:
hebasto:
ACK acf8abc7f3cf7efa418a46f9f69f23f1a5035582, I have reviewed the code and it looks OK, I agree it can be merged.
elichai:
utACK acf8abc7f3cf7efa418a46f9f69f23f1a5035582
kristapsk:
ACK acf8abc7f3cf7efa418a46f9f69f23f1a5035582
MarcoFalke:
ACK acf8abc7f3cf7efa418a46f9f69f23f1a5035582
Tree-SHA512: f5e6d873192d08d1a572e66e17c2e06d1ce27d01aa196b2a7ed591008641295bb02cda8ac90919ff2d2fc778316c2e143f8d36599e0d377779758853dfaf0a31
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions